Skip to content

KMS HMAC support #8047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 4, 2023
Merged

KMS HMAC support #8047

merged 9 commits into from
Apr 4, 2023

Conversation

sannya-singal
Copy link
Contributor

  • Added support for key specs - HMAC_224, HMAC_256, HMAC_384 and HMAC_512
  • Implemented CreateKey for hmac, GenerateMac and VerifyMac
  • Write test cases for them

Related issue #7736

@sannya-singal sannya-singal marked this pull request as draft April 3, 2023 09:44
@github-actions
Copy link

github-actions bot commented Apr 3, 2023 •
edited
Loading

LocalStack integration with Pro

1 889 tests  +20   1 691 ✔️ +11   1h 21m 38s ⏱️ - 2m 46s
       1 suites ±  0      198 💤 +  9 
       1 files   ±  0          0 ❌ ±  0 

Results for commit c76e9a5. ± Comparison against base commit 8f196a0.

♻️ This comment has been updated with latest results.

@sannya-singal sannya-singal marked this pull request as ready for review April 4, 2023 08:08
@sannya-singal sannya-singal self-assigned this Apr 4, 2023
viren-nadkarni
viren-nadkarni requested changes Apr 4, 2023
View reviewed changes
@coveralls
Copy link

coveralls commented Apr 4, 2023 •
edited
Loading

Coverage Status

Coverage: 81.891% (+0.01%) from 81.877% when pulling c76e9a5 on kms1 into 8f196a0 on master.

viren-nadkarni
viren-nadkarni reviewed Apr 4, 2023
View reviewed changes
@viren-nadkarni viren-nadkarni self-requested a review April 4, 2023 12:27
viren-nadkarni
viren-nadkarni approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from a small nit, LGTM ✔️

@sannya-singal sannya-singal merged commit cf32f3d into master Apr 4, 2023
@bentsku bentsku deleted the kms1 branch April 4, 2023 17:37
@bentsku bentsku restored the kms1 branch April 4, 2023 17:38
@sannya-singal sannya-singal deleted the kms1 branch April 5, 2023 06:29
@sannya-singal sannya-singal mentioned this pull request Apr 5, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

Assignees

@sannya-singal sannya-singal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sannya-singal @coveralls @viren-nadkarni