Skip to content

add implementation of DeleteChangeSet for CFnV2 #12876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add implementation of DeleteChangeSet for CFnV2 #12876

wants to merge 1 commit into from
+34 −3

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Jul 18, 2025

Motivation

This PR implements the DeleteChangeSet for Cloudformation v2 provider.

Changes

  • Operation implementation

Testing

  • Manual testing with tests.aws.services.cloudformation.api.test_changesets.test_delete_change_set_exception.
  • The logs pertaining to errors while deletion should be gone.

@pinzon pinzon added aws:cloudformation AWS CloudFormation semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Jul 18, 2025
@github-actions GitHub Actions
Copy link

Test Results - Preflight, Unit

21 862 tests  ±0   20 205 ✅ ±0   6m 12s ⏱️ -41s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 207a19d. ± Comparison against base commit 9bd5851.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   22m 6s ⏱️ - 1h 21m 37s
895 tests  - 4 034  331 ✅  - 3 820  564 💤  - 214  0 ❌ ±0 
897 runs   - 4 034  331 ✅  - 3 820  566 💤  - 214  0 ❌ ±0 

Results for commit 207a19d. ± Comparison against base commit 9bd5851.

This pull request removes 4034 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 6s ⏱️ -4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 207a19d. ± Comparison against base commit 9bd5851.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Integration, Bootstrap

  5 files  ±    0    5 suites  ±0   35m 6s ⏱️ - 1h 45m 36s
919 tests  - 4 369  356 ✅  - 4 001  563 💤  - 368  0 ❌ ±0 
925 runs   - 4 369  356 ✅  - 4 001  569 💤  - 368  0 ❌ ±0 

Results for commit 207a19d. ± Comparison against base commit 9bd5851.

This pull request removes 4369 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@pinzon pinzon marked this pull request as ready for review July 18, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
aws:cloudformation AWS CloudFormation semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pinzon