Skip to content

cleanup missed references to old naming #12869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

cleanup missed references to old naming #12869

merged 1 commit into from
Jul 17, 2025

Conversation

alexrashed
Copy link
Member

Motivation

As announced in #12849, we renamed our default branch yesterday.
This PR does perform a final cleanup of references which were missed in #12847.

Changes

  • Renames files that had master in the name.
  • Renames some references to our Pro codebase (which has also been renamed yesterday).

@alexrashed alexrashed added this to the 4.7 milestone Jul 17, 2025
@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Jul 17, 2025
@alexrashed alexrashed added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Jul 17, 2025
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, let's get rid of those references!

Copy link

Test Results - Preflight, Unit

21 862 tests  ±0   20 205 ✅ ±0   6m 24s ⏱️ -28s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit eb7de41. ± Comparison against base commit 7720cc4.

Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit eb7de41. ± Comparison against base commit 7720cc4.

Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 23m 25s ⏱️ + 2m 15s
5 288 tests ±0  4 358 ✅ ±0  930 💤 ±0  0 ❌ ±0 
5 294 runs  ±0  4 358 ✅ ±0  936 💤 ±0  0 ❌ ±0 

Results for commit eb7de41. ± Comparison against base commit 7720cc4.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 45m 37s ⏱️ + 1m 32s
4 929 tests ±0  4 151 ✅  - 1  777 💤 ±0  1 ❌ +1 
4 931 runs  ±0  4 151 ✅  - 1  779 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit eb7de41. ± Comparison against base commit 7720cc4.

@alexrashed
Copy link
Member Author

The failing test in the optional pipeline (Community Integration Tests against Pro) is a flake, I'll move forward and merge this PR.

@alexrashed alexrashed merged commit 3a47a8f into main Jul 17, 2025
42 of 44 checks passed
@alexrashed alexrashed deleted the rename-leftovers branch July 17, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants