Skip to content

CFNv2: Implement get_template #12865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CFNv2: Implement get_template #12865

wants to merge 2 commits into from

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Jul 15, 2025 •
edited
Loading

Motivation

The new provider does not support the GetTemplate operation. This PR implements an initial version.

Changes

  • Store a copy of the original (parsed but not transformed) template on the stack
  • Implement the provider method basically copying the v1 implementation
  • Unskip 3 tests

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Jul 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 862 tests  ±0   20 205 ✅ ±0   6m 22s ⏱️ +4s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 96caa53. ± Comparison against base commit 04aa2bc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 11s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 96caa53. ± Comparison against base commit 04aa2bc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   22m 34s ⏱️ - 1h 23m 59s
895 tests  - 4 034  331 ✅  - 3 821  564 💤  - 213  0 ❌ ±0 
897 runs   - 4 034  331 ✅  - 3 821  566 💤  - 213  0 ❌ ±0 

Results for commit 96caa53. ± Comparison against base commit 04aa2bc.

This pull request removes 4034 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   34m 24s ⏱️
919 tests 356 ✅ 563 💤 0 ❌
925 runs  356 ✅ 569 💤 0 ❌

Results for commit 96caa53.

♻️ This comment has been updated with latest results.

@simonrw simonrw force-pushed the cfn/v2/get-template branch from 757ff16 to 96caa53 Compare July 17, 2025 13:15
@simonrw simonrw marked this pull request as ready for review July 17, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simonrw