Skip to content

Fix ssm list parameter tags #12407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix ssm list parameter tags #12407

wants to merge 4 commits into from

Conversation

cloutierMat
Copy link
Contributor

Motivation

This pr fixes an issue where attempting to list tags for a parameter that starts with a / would fail if the parameter was not created with the leading slash.

Changes

  • patch moto to remove the leading slash for a non-nested parameter when attempting to list the tags
  • added test

@cloutierMat cloutierMat self-assigned this Mar 19, 2025
@cloutierMat cloutierMat added aws:ssm AWS Systems Manager semver: patch Non-breaking changes which can be included in patch releases labels Mar 19, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   20m 18s ⏱️ - 1h 31m 28s
438 tests  - 3 853  326 ✅  - 3 644  112 💤  - 209  0 ❌ ±0 
440 runs   - 3 853  326 ✅  - 3 644  114 💤  - 209  0 ❌ ±0 

Results for commit 65e6bf1. ± Comparison against base commit fcc4de7.

This pull request removes 3855 and adds 2 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.ssm.test_ssm.TestSSM ‑ test_list_tags_for_nested_parameter
tests.aws.services.ssm.test_ssm.TestSSM ‑ test_list_tags_for_parameter

♻️ This comment has been updated with latest results.

@cloutierMat cloutierMat marked this pull request as ready for review March 19, 2025 03:58
@cloutierMat cloutierMat modified the milestones: 4.3, 4.4 Mar 24, 2025
@cloutierMat cloutierMat marked this pull request as draft March 25, 2025 22:35
@cloutierMat cloutierMat modified the milestones: 4.4, Playground Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@cloutierMat cloutierMat

Labels
aws:ssm AWS Systems Manager semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
1 participant
@cloutierMat