Skip to content

Feature/EventBridge: Clearn up rule-processing logic #12302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxhoheiser
Copy link
Member

@maxhoheiser maxhoheiser commented Feb 24, 2025

Motivation

Only call _process_rule for rules that match the given event and its conditions.

Changes

Move matching of condition outside of process_rule logic.

@maxhoheiser maxhoheiser added aws:events Amazon EventBridge semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Feb 24, 2025
@maxhoheiser maxhoheiser self-assigned this Feb 24, 2025
@maxhoheiser maxhoheiser requested a review from joe4dev as a code owner February 24, 2025 18:12
Copy link

github-actions bot commented Feb 24, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 10m 6s ⏱️ - 43m 56s
2 497 tests  - 1 606  2 391 ✅  - 1 379  106 💤  - 227  0 ❌ ±0 
2 499 runs   - 1 606  2 391 ✅  - 1 379  108 💤  - 227  0 ❌ ±0 

Results for commit 20d99fb. ± Comparison against base commit 6f32581.

This pull request removes 1606 tests.
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@maxhoheiser maxhoheiser force-pushed the feature/events/fix-processing-rule-matching-logic branch from b204124 to 20d99fb Compare February 25, 2025 13:51
@maxhoheiser maxhoheiser modified the milestones: 4.2, Playground Feb 25, 2025
@maxhoheiser maxhoheiser marked this pull request as draft February 25, 2025 16:48
@joe4dev joe4dev removed their request for review March 17, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:events Amazon EventBridge semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant