Skip to content

Add Z flag in volume binds to support SELINUX #12238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fedemp
Copy link

@fedemp fedemp commented Feb 9, 2025

Motivation

This PR should fix #12237. localstack can't even start because the container can't correctly do a bind mount to the host if the host is running SELINUX

Changes

Add the Z option to bind mount. Specifically, adds the option when a VolumeBind is transformed into a string.

@dfangl dfangl closed this Feb 10, 2025
@dfangl dfangl reopened this Feb 10, 2025
@dfangl
Copy link
Member

dfangl commented Feb 10, 2025

FYI: There was some issue with circleci, I closed and reopened your PR to trigger the pipeline.

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Feb 19, 2025
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you broke some assertions with the change, can you go ahead and fix them? Also you would need to run make format please, otherwise our linting won't pass.

@k-a-il k-a-il added this to the Playground milestone Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: localstack start won't start due to SELINUX in Fedora Silverblue
4 participants