Update template_utils.py #12217
Update template_utils.py #12217
Conversation
fixed the assumption that every element is a dict might not be true.
0xDS
requested review from
dominikschubert,
pinzon and
simonrw
as code owners
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Thanks for making this contribution, however I think the TODO is more about our understanding. We would like to know: "are there any circumstances where a resource property (possibly nested) is a list of non-dicts".
This boils down to: is there a way in CloudFormation to refer to another resource without representing it as a dict.
Some dict examples:
Value:
Fn::Sub:
- "my-value-${Foo}"
- Foo: barValue:
Fn::Sub: "my-value-${LogicalResourceId}"Value:
Fn::Join:
- ""
- - "a"
- "b"Can you think of any such method in CloudFormation?
fixed the assumption that every element is a dict might not be true.
Motivation
Fixed todo in the code.