Skip to content

Feature/scheduler/extend tests coverage #12114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feature/scheduler/extend tests coverage #12114

wants to merge 4 commits into from

Conversation

maxhoheiser
Copy link
Member

@maxhoheiser maxhoheiser commented Jan 8, 2025 •
edited
Loading

Motivation

A user reported a regression for get_schedule error code if the schedule was not found. To better understand this and also other discovered regressions and response errors from MOTO (used for implementing event bridge scheduler. And as a preparation for implementing a native localstack event bridge scheduler this PR adds AWS snapshot tests for the CRUD functionality of event bridge scheduler (https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/scheduler.html)

The regressions are fixed in moto is this PR: getmoto/moto#8478

Changes

Add AWS snapshot tests for CRUD for schedules and schedule groups

@maxhoheiser maxhoheiser added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases aws:scheduler Amazon EventBridge Scheduler labels Jan 8, 2025
@maxhoheiser maxhoheiser self-assigned this Jan 8, 2025
@maxhoheiser maxhoheiser mentioned this pull request Jan 8, 2025
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

LocalStack Community integration with Pro

  2 files  ±    0   2 suites  ±0   38s ⏱️ - 1h 54m 54s
116 tests  - 3 827  47 ✅  - 3 587  2 💤  - 307  67 ❌ +67 
118 runs   - 3 827  47 ✅  - 3 587  4 💤  - 307  67 ❌ +67 

For more details on these failures, see this check.

Results for commit 108ac09. ± Comparison against base commit 0191993.

This pull request removes 3938 and adds 111 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_create_schedule[FLEXIBLE-DISABLED-DELETE-False-False]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_create_schedule[FLEXIBLE-DISABLED-DELETE-False-True]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_create_schedule[FLEXIBLE-DISABLED-DELETE-True-False]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_create_schedule[FLEXIBLE-DISABLED-DELETE-True-True]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_create_schedule[FLEXIBLE-DISABLED-NONE-False-False]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_create_schedule[FLEXIBLE-DISABLED-NONE-False-True]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_create_schedule[FLEXIBLE-DISABLED-NONE-True-False]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_create_schedule[FLEXIBLE-DISABLED-NONE-True-True]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_create_schedule[FLEXIBLE-ENABLED-DELETE-False-False]
tests.aws.services.scheduler.test_scheduler.TestSchedule ‑ test_create_schedule[FLEXIBLE-ENABLED-DELETE-False-True]
…

This was referenced Jan 8, 2025
Closed
Merged
@silv-io silv-io added this to the Playground milestone Jan 27, 2025
@joe4dev joe4dev removed their request for review March 17, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaingz zaingz Awaiting requested review from zaingz

At least 1 approving review is required to merge this pull request.

Assignees

@maxhoheiser maxhoheiser

Labels
aws:scheduler Amazon EventBridge Scheduler semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
2 participants
@maxhoheiser @silv-io