Skip to content

Remove DNS_LOCAL_NAME_PATTERNS #11876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove DNS_LOCAL_NAME_PATTERNS #11876

wants to merge 2 commits into from

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Nov 19, 2024

Motivation

We deprecated DNS_LOCAL_NAME_PATTERNS in LocalStack v3.0 as its name was confusing. We should now remove this variable.

Changes

  • Remove DNS_LOCAL_NAME_PATTERNS and all references to it

@simonrw simonrw added the semver: major Breaking changes which can be included in a major release only label Nov 19, 2024
@simonrw simonrw self-assigned this Nov 19, 2024
@simonrw simonrw requested a review from dfangl November 19, 2024 14:55
@localstack-bot
Copy link
Contributor

Currently, only minor and patch changes are allowed on master. Your PR labels (semver: major) indicate that it cannot be merged into the master at this time.

@github-actions GitHub Actions
Copy link

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   4m 3s ⏱️ +7s
421 tests ±0  369 ✅ ±0   52 💤 ±0  0 ❌ ±0 
842 runs  ±0  738 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit ece1d9c. ± Comparison against base commit f890150.

dfangl
dfangl reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the deprecating warning in, but rephrase it that it has been removed with 4.0, similar to what we do for other features as well. What do you think?

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 44m 0s ⏱️ +59s
3 542 tests ±0  3 135 ✅ ±0  407 💤 ±0  0 ❌ ±0 
3 544 runs  ±0  3 135 ✅ ±0  409 💤 ±0  0 ❌ ±0 

Results for commit ece1d9c. ± Comparison against base commit f890150.

@simonrw simonrw added this to the 5.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl left review comments

@thrau thrau Awaiting requested review from thrau thrau will be requested when the pull request is marked ready for review thrau is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@simonrw simonrw

Labels
semver: major Breaking changes which can be included in a major release only
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonrw @localstack-bot @dfangl