add support for downloading python dependancies using urls #10986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
reviewed
Jun 10, 2024
There was a problem hiding this comment.
I think it would make sense to implement this change together with a usage (in order to see the motivation for the change, as well as having a test for it). Another option would be to add (unit) tests for this installer (maybe by mocking the run command) which shows and tests the new feature.
macnev2013
added
the
semver: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR aims to add support to download python packages using urls like
git+https://github.com/localstack/aws-glue-libs.git@glue-0.9#egg=aws-glue-libsChanges
Testing