⚡️ perf: try to fix layout flick #8480
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's GuideRefactors sidebar navigation and layout composition to improve performance and flicker by extracting ChatAction, introducing a dynamic InnerLink with segmentVariants, switching to an async NewServerLayout, enhancing JWKS public key handling, and integrating OIDC authentication. Sequence diagram for OIDC authentication in checkAuth middlewaresequenceDiagram
participant Client
participant Middleware
participant OIDCProvider
Client->>Middleware: Send request with Oidc-Auth header
Middleware->>OIDCProvider: validateOIDCJWT(oidcAuthorization)
OIDCProvider-->>Middleware: OIDC payload (userId, ...)
Middleware->>Middleware: Merge OIDC userId into jwtPayload
Middleware->>Middleware: Skip checkAuthMethod if OIDC used
Class diagram for new and refactored navigation componentsclassDiagram
class TopActions {
+tab
+isPinned
}
class ChatAction {
+isPinned
+tab
}
class InnerLink {
+href
+children
+...props
}
TopActions --> ChatAction : uses
TopActions --> InnerLink : uses
ChatAction --> InnerLink : uses
Class diagram for new ServerLayout and related layout changesclassDiagram
class ServerLayout {
+Desktop
+Mobile
+children
}
class RouteVariants {
+getIsMobile(props)
}
ServerLayout ..> RouteVariants : uses
Class diagram for server config store changesclassDiagram
class ServerConfigState {
+featureFlags: IFeatureFlags
+isMobile?: boolean
+segmentVariants?: string
+serverConfig: GlobalServerConfig
}
class ServerConfigStoreProvider {
+featureFlags?
+isMobile?
+segmentVariants?
+serverConfig?
+children
}
ServerConfigStoreProvider --> ServerConfigState : provides
Class diagram for OIDC JWT verification refactorclassDiagram
class getVerificationKey {
+async()
}
class validateOIDCJWT {
+async(token: string)
}
validateOIDCJWT --> getVerificationKey : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8480 +/- ##
===========================================
+ Coverage 85.31% 96.26% +10.94%
===========================================
Files 907 17 -890
Lines 68464 2917 -65547
Branches 6268 515 -5753
===========================================
- Hits 58413 2808 -55605
+ Misses 10051 109 -9942
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
👍 @arvinxx Thank you for raising your pull request and contributing to our Community |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
📝 补充信息 | Additional Information
Summary by Sourcery
Implement OIDC authentication support, introduce URL segment variant routing, refactor sidebar and server layouts to reduce flicker and unify link handling, and fix JWT public key import.
New Features:
Oidc-Authheader in middleware and tRPC context.segmentVariantsproperty in the server config store and theInnerLinkcomponent.Bug Fixes:
getVerificationKey.Enhancements:
ChatActioncomponent and replace directnext/linkusage in sidebar withInnerLinkfor consistent routing.NewServerLayoutfor unified desktop/mobile rendering and refactor chat workspace layout to pass props asynchronously.LOBE_CHAT_OIDC_AUTH_HEADERconstant for header consistency.