Skip to content

💄 style: fix sub topic width in md responsive #8443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

💄 style: fix sub topic width in md responsive #8443

wants to merge 2 commits into from

Conversation

ONLY-yours
Copy link
Collaborator

@ONLY-yours ONLY-yours commented Jul 15, 2025 •
edited by arvinxx
Loading

💻 变更类型 | Change Type

修复小屏幕下 子 topic 的最小宽度不正确的问题

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-database ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2025 2:51pm
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2025 2:51pm

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jul 15, 2025 •
edited
Loading

Reviewer's Guide

The pull request refines the PortalPanel width logic to prevent sub-topic overflow on small screens by incorporating the md breakpoint into the minWidth calculation.

File-Level Changes

Change Details Files
Refine PortalPanel.minWidth logic to respect md breakpoint
  • Add md flag check in the tool UI width condition
  • Fallback to default chat portal width on non-md screens
 src/app/[variants]/(main)/chat/(workspace)/_layout/Desktop/Portal.tsx
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@lobehubbot
Copy link
Member

👍 @ONLY-yours

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@gru-agent Gru Agent
Copy link
Contributor

gru-agent bot commented Jul 15, 2025 •
edited
Loading

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 726f5da 🚫 Skipped No files need to be tested {"src/app/[variants]/(main)/chat/(workspace)/_layout/Desktop/Portal.tsx":"File path does not match include patterns."}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ONLY-yours - I've reviewed your changes - here's some feedback:

  • Consider extracting the combined showArtifactUI/showToolUI/showThread && md check into a named variable or helper to improve readability of the minWidth expression.
  • Add a brief inline comment explaining the purpose of the md flag in determining minWidth so future maintainers understand why tool UI width only applies on medium screens.
Prompt for AI Agents 
Please address the comments from this code review:
## Overall Comments
- Consider extracting the combined showArtifactUI/showToolUI/showThread && md check into a named variable or helper to improve readability of the minWidth expression.
- Add a brief inline comment explaining the purpose of the md flag in determining minWidth so future maintainers understand why tool UI width only applies on medium screens.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐛 Bug Something isn't working | 缺陷 labels Jul 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.49%. Comparing base (a55b65b) to head (b3f6ad3).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8443   +/-   ##
=======================================
  Coverage   85.49%   85.49%           
=======================================
  Files         903      903           
  Lines       68224    68224           
  Branches     6252     6252           
=======================================
  Hits        58331    58331           
  Misses       9893     9893
Flag Coverage Δ
app 85.49% <ø> (ø)
server 96.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx arvinxx changed the title fix: 修复非 md 宽度下 sub topic 宽度溢出的问题 💄 style: fix sub topic width in md responsive Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
🐛 Bug Something isn't working | 缺陷 size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ONLY-yours @lobehubbot @arvinxx