[NFC][RA] Refactor RABasic into a Separate Header #149555
Open
+110
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors the RABasic type by moving it from RegAllocBasic.cpp to a new header file, RegAllocBasic.h. This separation of header and implementation aligns with the structure used by other register allocators, such as RegAllocGreedy. The refactoring is intended to facilitate future use of RABasic in other contexts.
kyulee-com
requested review from
MatzeB,
ellishg,
akshaykhadse,
DataCorrupted,
cdevadas and
jurahul
MatzeB
reviewed
Jul 18, 2025
llvm/lib/CodeGen/RegAllocBasic.h
Outdated
Comment on lines
9
to
10
| // This file declares the RABasic class, which provides a minimal | ||
| // implementation of the basic register allocator. |
There was a problem hiding this comment.
use syntax recognized by doxygen (and possibly fix the pre-existing problem in RegAllocBasic.cpp)
Suggested change
| // This file declares the RABasic class, which provides a minimal | |
| // implementation of the basic register allocator. | |
| /// \file This file declares the RABasic class, which provides a minimal | |
| /// implementation of the basic register allocator. |
llvm/lib/CodeGen/RegAllocBasic.h
Outdated
Comment on lines
14
to
15
| #ifndef LLVM_CODEGEN_REGALLOCBAISC_H_ | ||
| #define LLVM_CODEGEN_REGALLOCBAISC_H_ |
There was a problem hiding this comment.
Suggested change
| #ifndef LLVM_CODEGEN_REGALLOCBAISC_H_ | |
| #define LLVM_CODEGEN_REGALLOCBAISC_H_ | |
| #ifndef LLVM_CODEGEN_REGALLOCBASIC_H | |
| #define LLVM_CODEGEN_REGALLOCBASIC_H |
There was a problem hiding this comment.
most files tend to use LLVM_LIB_CODEGEN_XXXX_H it seems...
llvm/lib/CodeGen/RegAllocBasic.h
Outdated
| static char ID; | ||
| }; | ||
| } // namespace llvm | ||
| #endif // #ifndef LLVM_CODEGEN_REGALLOCBAISC_H_ |
There was a problem hiding this comment.
Suggested change
| #endif // #ifndef LLVM_CODEGEN_REGALLOCBAISC_H_ | |
| #endif |
llvm/lib/CodeGen/RegAllocBasic.h
Outdated
Comment on lines
19
to
24
| #include "llvm/CodeGen/LiveIntervals.h" | ||
| #include "llvm/CodeGen/LiveRangeEdit.h" | ||
| #include "llvm/CodeGen/LiveRegMatrix.h" | ||
| #include "llvm/CodeGen/MachineFunctionPass.h" | ||
| #include "llvm/CodeGen/Spiller.h" | ||
| #include "llvm/CodeGen/VirtRegMap.h" |
There was a problem hiding this comment.
Please check which include files are actually needed, and which ones can be replaced with class xxx; forward declarations. LiveRegMatrix and VirtRegMap seem unused at a first glance...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the RABasic type by moving it from RegAllocBasic.cpp to a new header file, RegAllocBasic.h. This separation of header and implementation aligns with the structure used by other register allocators, such as RegAllocGreedy. The refactoring is intended to facilitate future use of RABasic in other contexts.