[flang][NFC] Fix build-time warning #149549
Merged
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't increment the LHS variable of an assignment that also uses that variable on the RHS.
llvmbot
added
flang
|
@llvm/pr-subscribers-flang-semantics Author: Peter Klausler (klausler) ChangesDon't increment the LHS variable of an assignment that also uses that variable on the RHS. Full diff: https://github.com/llvm/llvm-project/pull/149549.diff 1 Files Affected:
diff --git a/flang/lib/Semantics/resolve-labels.cpp b/flang/lib/Semantics/resolve-labels.cpp
index 27e259fab38738..9454ef9fe928ad 100644
--- a/flang/lib/Semantics/resolve-labels.cpp
+++ b/flang/lib/Semantics/resolve-labels.cpp
@@ -492,10 +492,9 @@ class ParseTreeAnalyzer {
// Uppercase the name of the main program, so that its symbol name
// would be unique from similarly named non-main-program symbols.
auto upperCaseCharBlock = [](const parser::CharBlock &cb) {
- char *ch{const_cast<char *>(cb.begin())};
- char *endCh{ch + cb.size()};
- while (ch != endCh) {
- *ch++ = parser::ToUpperCaseLetter(*ch);
+ auto ch{const_cast<char *>(cb.begin())};
+ for (char *endCh{ch + cb.size()}; ch != endCh; ++ch) {
+ *ch = parser::ToUpperCaseLetter(*ch);
}
};
const parser::CharBlock *progName{nullptr};
|
eugeneepshteyn
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't increment the LHS variable of an assignment that also uses that variable on the RHS.