-
Notifications
You must be signed in to change notification settings - Fork 14.5k
[libcxx] Switch to release branch runners #149385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/21.x
Are you sure you want to change the base?
[libcxx] Switch to release branch runners #149385
Conversation
This ensures that if/when we bump the toolchain versions in the main container that we do not break tests on the release branch.
@llvm/pr-subscribers-libcxx @llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis ensures that if/when we bump the toolchain versions in the main container that we do not break tests on the release branch. Full diff: https://github.com/llvm/llvm-project/pull/149385.diff 1 Files Affected:
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index ec937de02ca1a..a5be912b1ab07 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -36,7 +36,7 @@ concurrency:
jobs:
stage1:
if: github.repository_owner == 'llvm'
- runs-on: llvm-premerge-libcxx-runners
+ runs-on: llvm-premerge-libcxx-release-runners
continue-on-error: false
strategy:
fail-fast: false
@@ -73,7 +73,7 @@ jobs:
**/crash_diagnostics/*
stage2:
if: github.repository_owner == 'llvm'
- runs-on: llvm-premerge-libcxx-runners
+ runs-on: llvm-premerge-libcxx-release-runners
needs: [ stage1 ]
continue-on-error: false
strategy:
@@ -147,19 +147,19 @@ jobs:
'generic-static',
'bootstrapping-build'
]
- machine: [ 'llvm-premerge-libcxx-runners' ]
+ machine: [ 'llvm-premerge-libcxx-release-runners' ]
include:
- config: 'generic-cxx26'
- machine: llvm-premerge-libcxx-runners
+ machine: llvm-premerge-libcxx-release-runners
- config: 'generic-asan'
- machine: llvm-premerge-libcxx-runners
+ machine: llvm-premerge-libcxx-release-runners
- config: 'generic-tsan'
- machine: llvm-premerge-libcxx-runners
+ machine: llvm-premerge-libcxx-release-runners
- config: 'generic-ubsan'
- machine: llvm-premerge-libcxx-runners
+ machine: llvm-premerge-libcxx-release-runners
# Use a larger machine for MSAN to avoid timeout and memory allocation issues.
- config: 'generic-msan'
- machine: llvm-premerge-libcxx-runners
+ machine: llvm-premerge-libcxx-release-runners
runs-on: ${{ matrix.machine }}
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! It's nice that it seems to "just work" -- I love it.
This ensures that if/when we bump the toolchain versions in the main container that we do not break tests on the release branch.