Skip to content

release/21.x: [CI][Github] Switch windows to server 2022 (#148743) #149128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

llvmbot
Copy link
Member

@llvmbot llvmbot commented Jul 16, 2025

Backport 3248a6d

Requested by: @boomanaiden154

@llvmbot
Copy link
Member Author

llvmbot commented Jul 16, 2025

@cmtice What do you think about merging this PR to the release branch?

@llvmbot
Copy link
Member Author

llvmbot commented Jul 16, 2025

@llvm/pr-subscribers-github-workflow

Author: None (llvmbot)

Changes

Backport 3248a6d

Requested by: @boomanaiden154


Full diff: https://github.com/llvm/llvm-project/pull/149128.diff

1 Files Affected:

  • (modified) .github/workflows/premerge.yaml (+1-1)
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index f7a48304b82b0..ff63355222065 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -76,7 +76,7 @@ jobs:
     if: >-
         github.repository_owner == 'llvm' &&
         (github.event_name != 'pull_request' || github.event.action != 'closed')
-    runs-on: llvm-premerge-windows-runners
+    runs-on: llvm-premerge-windows-2022-runners
     defaults:
       run:
         shell: bash

@boomanaiden154
Copy link
Contributor

@tru The plan is to use the new premerge CI to test changes to the release branch, right?

We're planning on backporting any changes that we're making in main to make sure the release branch CI still works, assuming that is actually the plan.

@github-project-automation github-project-automation bot moved this from Needs Triage to Needs Merge in LLVM Release Status Jul 16, 2025
@cmtice
Copy link
Contributor

cmtice commented Jul 16, 2025

@cmtice What do you think about merging this PR to the release branch?

SGTM.

@tru
Copy link
Collaborator

tru commented Jul 17, 2025

@tru The plan is to use the new premerge CI to test changes to the release branch, right?

We're planning on backporting any changes that we're making in main to make sure the release branch CI still works, assuming that is actually the plan.

Yes please.

This patch switches the windows testing over to server 2022 by switching
to the recently introduced runner set.

(cherry picked from commit 3248a6d)
@tru tru merged commit 46c566f into llvm:release/21.x Jul 17, 2025
1 check was pending
@github-project-automation github-project-automation bot moved this from Needs Merge to Done in LLVM Release Status Jul 17, 2025
Copy link

@boomanaiden154 (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants