[flang][cuda] Update condition in descriptor data transfer #148306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangzpgi
reviewed
Jul 11, 2025
| // Special case when rhs is bigger than lhs and both are contiguous arrays. | ||
| // In this case we do a simple ptr to ptr transfer with the size of lhs. | ||
| // This is be allowed in the reference compiler and it avoids error | ||
| // triggered in the Assign runtime function used for the main case below. | ||
| if (!srcDesc->IsContiguous() || !dstDesc->IsContiguous()) | ||
| terminator.Crash("Unsupported data transfer: mismatching element counts " | ||
| "with non-contiguous arrays"); |
There was a problem hiding this comment.
Is my understanding correct that both new and old version achieve the same goal of only allowing contiguous arrays for the data transfer, but the old version gives an error message about unsupported data transfer?
There was a problem hiding this comment.
Ah! I see there is a difference between <= and <. Didn't notice it.
There was a problem hiding this comment.
Yeah and the new version fall back on the runtime assign function instead of giving an error.
wangzpgi
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the two descriptor have the same number of elements and are contiguous, the transfer can be done via pointers.