libxmlplusplus · neheb · Jul 2, 2022 · Jul 2, 2022
diff --git a/examples/dom_update_namespace/main.cc b/examples/dom_update_namespace/main.cc
@@ -29,7 +29,7 @@
 class Tests
 {
   public:
-    virtual ~Tests() {}
+    virtual ~Tests() = default;
 
   protected:
     template<typename RefType, typename ValueType>
@@ -45,7 +45,7 @@ class fail_exception : public std::exception
 {
   public:
     explicit fail_exception(const std::string& msg) : msg_(msg) {}
-    ~fail_exception() noexcept override {}
+    ~fail_exception() noexcept override = default;
     const char* what() const noexcept override { return msg_.c_str(); }
 
   private:
@@ -67,13 +67,11 @@ class TestNamespace : public Tests
 
     xmlpp::Node::PrefixNsMap nsmap_;
     xmlpp::DomParser parser_;
-    xmlpp::Element* root_;
+    xmlpp::Element *root_{nullptr};
 };
 
-
 TestNamespace::TestNamespace()
-:
-root_(nullptr)
+
 {
   nsmap_["ns0"] = "http://default.namespace/root";
   nsmap_["ns1"] = "http://default.namespace/child";

diff --git a/examples/sax_exception/myparser.cc b/examples/sax_exception/myparser.cc
@@ -46,13 +46,9 @@ xmlpp::exception* MyException::clone() const
  * MySaxParser implementation
  */
 
-MySaxParser::MySaxParser()
-{
-}
+MySaxParser::MySaxParser() = default;
 
-MySaxParser::~MySaxParser()
-{
-}
+MySaxParser::~MySaxParser() = default;
 
 void MySaxParser::on_start_document()
 {

diff --git a/examples/sax_parser/myparser.cc b/examples/sax_parser/myparser.cc
@@ -28,9 +28,7 @@ MySaxParser::MySaxParser()
 {
 }
 
-MySaxParser::~MySaxParser()
-{
-}
+MySaxParser::~MySaxParser() = default;
 
 void MySaxParser::on_start_document()
 {

diff --git a/examples/sax_parser_build_dom/svgelement.cc b/examples/sax_parser_build_dom/svgelement.cc
@@ -27,8 +27,7 @@ Element::Element(xmlNode* node)
   : xmlpp::Element(node)
 {}
 
-Element::~Element()
-{}
+Element::~Element() = default;
 
 // example custom methods
 void Element::set_style(const xmlpp::ustring& style)

diff --git a/examples/sax_parser_build_dom/svgparser.cc b/examples/sax_parser_build_dom/svgparser.cc
@@ -35,9 +35,7 @@ Parser::Parser(xmlpp::Document& document)
   set_substitute_entities(true);
 }
 
-Parser::~Parser()
-{
-}
+Parser::~Parser() = default;
 
 void Parser::on_start_element(const xmlpp::ustring& name,
                                    const AttributeList& attributes)

diff --git a/examples/sax_parser_entities/myparser.cc b/examples/sax_parser_entities/myparser.cc
@@ -26,9 +26,7 @@ MySaxParser::MySaxParser()
 {
 }
 
-MySaxParser::~MySaxParser()
-{
-}
+MySaxParser::~MySaxParser() = default;
 
 void MySaxParser::on_start_document()
 {

diff --git a/libxml++/attribute.cc b/libxml++/attribute.cc
@@ -16,8 +16,6 @@ Attribute::Attribute(xmlNode* node)
 {
 }
 
-Attribute::~Attribute()
-{
-}
+Attribute::~Attribute() = default;
 
 } //namespace xmlpp
diff --git a/libxml++/attributedeclaration.cc b/libxml++/attributedeclaration.cc
@@ -16,9 +16,7 @@ AttributeDeclaration::AttributeDeclaration(xmlNode* node)
 {
 }
 
-AttributeDeclaration::~AttributeDeclaration()
-{
-}
+AttributeDeclaration::~AttributeDeclaration() = default;
 
 ustring AttributeDeclaration::get_value() const
 {

diff --git a/libxml++/attributenode.cc b/libxml++/attributenode.cc
@@ -16,9 +16,7 @@ AttributeNode::AttributeNode(xmlNode* node)
 {
 }
 
-AttributeNode::~AttributeNode()
-{
-}
+AttributeNode::~AttributeNode() = default;
 
 ustring AttributeNode::get_value() const
 {

diff --git a/libxml++/document.cc b/libxml++/document.cc
@@ -154,19 +154,16 @@ Document::Init::Init()
   xmlInitParser(); //Not always necessary, but necessary for thread safety.
 }
 
-Document::Init::~Init() noexcept
-{
-  //We don't call this because it breaks libxml generally and should only be
-  //called at the very end of a process, such as at the end of a main().
-  //libxml might still be used by the application, so we don't want to break
-  //that.
-  //This is important even here, which usually happens only when the library
-  //is unloaded, because that might happen during normal application use,
-  //if the application does dynamic library loading, for instance to load
-  //plugins.
-  //See http://xmlsoft.org/html/libxml-parser.html#xmlCleanupParser
-  //xmlCleanupParser(); //As per xmlInitParser(), or memory leak will happen.
-}
+//We don't call this because it breaks libxml generally and should only be
+//called at the very end of a process, such as at the end of a main().
+//libxml might still be used by the application, so we don't want to break
+//that.
+//This is important even here, which usually happens only when the library
+//is unloaded, because that might happen during normal application use,
+//if the application does dynamic library loading, for instance to load
+//plugins.
+//See http://xmlsoft.org/html/libxml-parser.html#xmlCleanupParser
+//xmlCleanupParser(); //As per xmlInitParser(), or memory leak will happen.
 
 Document::Init Document::init_;
 

diff --git a/libxml++/document.h b/libxml++/document.h
@@ -69,7 +69,7 @@ class Document : public NonCopyable
   {
   public:
     Init();
-    ~Init() noexcept;
+    ~Init() noexcept = default;
   };
 
   friend LIBXMLPP_API class SaxParser;

diff --git a/libxml++/dtd.cc b/libxml++/dtd.cc
@@ -17,10 +17,10 @@ namespace xmlpp
 
 struct Dtd::Impl
 {
-  Impl() noexcept : dtd(nullptr), is_dtd_owner(false) {}
+  Impl() noexcept = default;
 
-  _xmlDtd* dtd;
-  bool is_dtd_owner;
+  _xmlDtd *dtd{nullptr};
+  bool is_dtd_owner{false};
 };
 
 Dtd::Dtd()

diff --git a/libxml++/exceptions/exception.cc b/libxml++/exceptions/exception.cc
@@ -11,8 +11,7 @@ exception::exception(const ustring& message)
 {
 }
 
-exception::~exception() noexcept
-{}
+exception::~exception() noexcept = default;
 
 const char* exception::what() const noexcept
 {

diff --git a/libxml++/exceptions/internal_error.cc b/libxml++/exceptions/internal_error.cc
@@ -7,8 +7,7 @@ internal_error::internal_error(const ustring& message)
 {
 }
 
-internal_error::~internal_error() noexcept
-{}
+internal_error::~internal_error() noexcept = default;
 
 void internal_error::raise() const
 {

diff --git a/libxml++/exceptions/parse_error.cc b/libxml++/exceptions/parse_error.cc
@@ -7,8 +7,7 @@ parse_error::parse_error(const ustring& message)
 {
 }
 
-parse_error::~parse_error() noexcept
-{}
+parse_error::~parse_error() noexcept = default;
 
 void parse_error::raise() const
 {

diff --git a/libxml++/exceptions/validity_error.cc b/libxml++/exceptions/validity_error.cc
@@ -7,8 +7,7 @@ validity_error::validity_error(const ustring& message)
 {
 }
 
-validity_error::~validity_error() noexcept
-{}
+validity_error::~validity_error() noexcept = default;
 
 void validity_error::raise() const
 {

diff --git a/libxml++/exceptions/wrapped_exception.cc b/libxml++/exceptions/wrapped_exception.cc
@@ -27,9 +27,7 @@ wrapped_exception::wrapped_exception(std::exception_ptr exception_ptr)
 {
 }
 
-wrapped_exception::~wrapped_exception() noexcept
-{
-}
+wrapped_exception::~wrapped_exception() noexcept = default;
 
 void wrapped_exception::raise() const
 {

diff --git a/libxml++/io/istreamparserinputbuffer.cc b/libxml++/io/istreamparserinputbuffer.cc
@@ -17,9 +17,7 @@ namespace xmlpp
   {
   }
 
-  IStreamParserInputBuffer::~IStreamParserInputBuffer()
-  {
-  }
+  IStreamParserInputBuffer::~IStreamParserInputBuffer() = default;
 
   int IStreamParserInputBuffer::do_read(
       char * buffer,

diff --git a/libxml++/io/ostreamoutputbuffer.cc b/libxml++/io/ostreamoutputbuffer.cc
@@ -18,9 +18,7 @@ namespace xmlpp
   {
   }
 
-  OStreamOutputBuffer::~OStreamOutputBuffer()
-  {
-  }
+  OStreamOutputBuffer::~OStreamOutputBuffer() = default;
 
   bool OStreamOutputBuffer::do_write(
       const char * buffer,

diff --git a/libxml++/io/outputbuffer.cc b/libxml++/io/outputbuffer.cc
@@ -67,9 +67,7 @@ namespace xmlpp
     }
   }
 
-  OutputBuffer::~OutputBuffer()
-  {
-  }
+  OutputBuffer::~OutputBuffer() = default;
 
   bool OutputBuffer::on_close()
   {

diff --git a/libxml++/io/parserinputbuffer.cc b/libxml++/io/parserinputbuffer.cc
@@ -45,9 +45,7 @@ namespace xmlpp
     }
   }
 
-  ParserInputBuffer::~ParserInputBuffer()
-  {
-  }
+  ParserInputBuffer::~ParserInputBuffer() = default;
 
   bool ParserInputBuffer::on_close()
   {

diff --git a/libxml++/nodes/cdatanode.cc b/libxml++/nodes/cdatanode.cc
@@ -15,7 +15,6 @@ CdataNode::CdataNode(xmlNode* node)
 : ContentNode(node)
 {}
 
-CdataNode::~CdataNode()
-{}
+CdataNode::~CdataNode() = default;
 
 } //namespace xmlpp
diff --git a/libxml++/nodes/commentnode.cc b/libxml++/nodes/commentnode.cc
@@ -15,8 +15,7 @@ CommentNode::CommentNode(xmlNode* node)
 : ContentNode(node)
 {}
 
-CommentNode::~CommentNode()
-{}
+CommentNode::~CommentNode() = default;
 
 } //namespace xmlpp
 
diff --git a/libxml++/nodes/contentnode.cc b/libxml++/nodes/contentnode.cc
@@ -16,8 +16,7 @@ ContentNode::ContentNode(xmlNode* node)
 : Node(node)
 {}
 
-ContentNode::~ContentNode()
-{}
+ContentNode::~ContentNode() = default;
 
 ustring ContentNode::get_content() const
 {

diff --git a/libxml++/nodes/element.cc b/libxml++/nodes/element.cc
@@ -33,8 +33,7 @@ Element::Element(xmlNode* node)
 : Node(node)
 {}
 
-Element::~Element()
-{}
+Element::~Element() = default;
 
 Element::AttributeList Element::get_attributes()
 {

diff --git a/libxml++/nodes/entitydeclaration.cc b/libxml++/nodes/entitydeclaration.cc
@@ -14,8 +14,7 @@ EntityDeclaration::EntityDeclaration(xmlNode* node)
 : ContentNode(node)
 {}
 
-EntityDeclaration::~EntityDeclaration()
-{}
+EntityDeclaration::~EntityDeclaration() = default;
 
 ustring EntityDeclaration::get_resolved_text() const
 {

diff --git a/libxml++/nodes/entityreference.cc b/libxml++/nodes/entityreference.cc
@@ -15,8 +15,7 @@ EntityReference::EntityReference(xmlNode* node)
 : Node(node)
 {}
 
-EntityReference::~EntityReference()
-{}
+EntityReference::~EntityReference() = default;
 
 ustring EntityReference::get_resolved_text() const
 {

diff --git a/libxml++/nodes/node.cc b/libxml++/nodes/node.cc
@@ -225,8 +225,7 @@ Node::Node(xmlNode* node)
   impl_->_private = this;
 }
 
-Node::~Node()
-{}
+Node::~Node() = default;
 
 const Element* Node::get_parent() const
 {

diff --git a/libxml++/nodes/processinginstructionnode.cc b/libxml++/nodes/processinginstructionnode.cc
@@ -15,7 +15,6 @@ ProcessingInstructionNode::ProcessingInstructionNode(xmlNode* node)
 : ContentNode(node)
 {}
 
-ProcessingInstructionNode::~ProcessingInstructionNode()
-{}
+ProcessingInstructionNode::~ProcessingInstructionNode() = default;
 
 } //namespace xmlpp
diff --git a/libxml++/nodes/textnode.cc b/libxml++/nodes/textnode.cc
@@ -15,7 +15,6 @@ TextNode::TextNode(xmlNode* node)
 : ContentNode(node)
 {}
 
-TextNode::~TextNode()
-{}
+TextNode::~TextNode() = default;
 
 } //namespace xmlpp
diff --git a/libxml++/nodes/xincludeend.cc b/libxml++/nodes/xincludeend.cc
@@ -26,7 +26,6 @@ XIncludeEnd::XIncludeEnd(xmlNode* node)
 : Node(node)
 {}
 
-XIncludeEnd::~XIncludeEnd()
-{}
+XIncludeEnd::~XIncludeEnd() = default;
 
 } //namespace xmlpp
diff --git a/libxml++/nodes/xincludestart.cc b/libxml++/nodes/xincludestart.cc
@@ -26,7 +26,6 @@ XIncludeStart::XIncludeStart(xmlNode* node)
 : Node(node)
 {}
 
-XIncludeStart::~XIncludeStart()
-{}
+XIncludeStart::~XIncludeStart() = default;
 
 } //namespace xmlpp
diff --git a/libxml++/noncopyable.cc b/libxml++/noncopyable.cc
@@ -10,12 +10,8 @@
 namespace xmlpp
 {
 
-NonCopyable::NonCopyable() noexcept
-{
-}
+NonCopyable::NonCopyable() noexcept = default;
 
-NonCopyable::~NonCopyable()
-{
-}
+NonCopyable::~NonCopyable() = default;
 
 } //namespace xmlpp
-Original file line number
+Diff line change
@@ Expand Up / @@ -28,9 +28,7 @@ MySaxParser::MySaxParser() @@
     {
     }
-    MySaxParser::~MySaxParser()
-    {
-    }
+    MySaxParser::~MySaxParser() = default;
     void MySaxParser::on_start_document()
     {
@@ Expand Down @@