Expose the assume-unchanged flag to IndexEntry #928 #929
Conversation
Created through the following
$ git init assume_unchanged_wd && cd assume_unchanged_wd
$ echo "hello" > hello.txt
$ echo "world" > world.txt
$ git add .
$ git commit -m "Initial commit"
$ echo "Hello" > hello.txt
$ echo "World" > world.txt
$ git status
On branch master
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: hello.txt
modified: world.txt
no changes added to commit (use "git add" and/or "git commit -a")
$ git update-index --assume-unchanged world.txt
$ git status
On branch master
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: hello.txt
no changes added to commit (use "git add" and/or "git commit -a")
| @@ -31,6 +31,11 @@ public class IndexEntry : IEquatable<IndexEntry> | |||
| public virtual StageLevel StageLevel { get; private set; } | |||
|
|
|||
| /// <summary> | |||
| /// Whether the file is marked as assume-unchanged | |||
| /// </summary> | |||
| public bool AssumeUnchanged { get; private set; } | |||
There was a problem hiding this comment.
Please mark this property as virtual. This should allow the build to pass 😉
|
Beside the tiny nitpick above, I ❤️ this very much 👍 One thing would be even awesomer: While amending your commit, could you please reword its commit message so that the reference to the issue is on the third line? Hint: If you write Something like this maybe Another thing. You may be willing to update your GitHub profile and add the email address you've used in this commit as a known one. This way, your contributions will be linked to your GitHub account. |
|
🆒 One last request. As the second commit is only a fixup of the first one, would you please squash them together? |
zpete
force-pushed
the
zpete/assume_unchanged
branch
from
fdcacc9 to
6f16791
Compare
|
Thank you very much for all the useful help. I hope everything is fine with On Fri, Jan 23, 2015 at 8:44 PM, nulltoken notifications@github.com wrote:
|
|
👍 as we get more flags, we'd eventually want to create its own type, like we have for the other flags, but for one it's fine as it is. |
|
👍 for me as well. |
Expose the assume-unchanged flag to IndexEntry
|
@zpete ✨ ✨ ✨ ✨ ✨ ✨ ✨ |
Didn't know where to put the constant GIT_IDXENTRY_VALID to - I hope LibGit2Sharp/Core/GitIndexEntry.cs is the right place.
This is my first Pull request, so bear with me.