Skip to content

V1.0 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: v1.0
Choose a base branch
from
Open

V1.0 #194

wants to merge 4 commits into from

Conversation

libla
Copy link

@libla libla commented Sep 28, 2015

  • update libuv depends to 1.0
  • fix assert error(for uv_loop_close)
  • fix some warning && syntax error
  • replace snprintf with cross platform

@LinuxJedi
Copy link
Member

so far looks great, I think CLang might complain but we can check that later. A couple of questions:

  1. Why the change from iso646.h way of doing things?
  2. Can you commit the missing install-libuv.sh?

@libla
Copy link
Author

libla commented Sep 30, 2015

  1. Because the visual studio isn't include the iso646.h by default, and in some platform isn't supported.
  2. This is my negligence.I'll add it immediately.

@LinuxJedi
Copy link
Member

  1. ah! I'm not a Windows guy so don't know much about what works in VS. I'm Completely OK with that then
  2. Excellent, thanks, but you forgot to set the executable bit on the file so Travis still breaks with it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@libla @LinuxJedi