pg_stat_statements: Allow interrupts whilst reading query text file #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the query text file gets very large (hundreds of megabytes, or more) and when limited I/O capacity is available, reading it can take many seconds, or even minutes. In such situations we want statement timeouts and query cancellations to allow canceling the read half-way through. To support this, check for interrupts, and read 100MB at a time, instead of 1GB as before.
lfittl
force-pushed
the
pgss-interruptible-query-text-file-reads
branch
from
b6ddb08 to
e2ec1e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the query text file gets very large (hundreds of megabytes, or more) and when limited I/O capacity is available, reading it can take many seconds, or even minutes.
In such situations we want statement timeouts and query cancellations to allow canceling the read half-way through. To support this, check for interrupts, and read 100MB at a time, instead of 1GB as before.