-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for imshow() #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PS -- I'm happy to write some example code for this if you'd like. |
Yes, please. Ideally this would also be called out elsewhere in the README, since it's quite a big change, introducing additional optional dependencies. |
Hi @lava, As of 52931d5 this branch is up-to-date with master, and as of c7f73bb it includes a basic example (ignoring OpenCV stuff). I am going to use your library, and it would be great to see @alexdewar's Thanks for building the interface! |
Hey, sorry for taking so long to merge such a nice PR. I finally took the time now to squash and merge it. Thanks for contributing to both of you! |
This PR adds support for the imshow() function to matplotlibcpp. imshow() displays an image in the current figure and allows for setting extra parameters such as the colormap used.
I've also added a version of the function which takes an OpenCV matrix as an input (in a separate commit), which provides a nicer interface. This requires OpenCV, but I've made this functionality optional: you have to explicitly define WITH_OPENCV if you want it.