fix(flushing): flush interval to millis in SpanProcessor #1244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Convert
flush_interval
to milliseconds inLangfuseSpanProcessor
and update documentation forLANGFUSE_FLUSH_INTERVAL
.flush_interval
from seconds to milliseconds inLangfuseSpanProcessor.__init__()
inspan_processor.py
.LANGFUSE_FLUSH_INTERVAL
documentation inenvironment_variables.py
to specify delay is in seconds.schedule_delay_millis
calculation inLangfuseSpanProcessor.__init__()
to handleNone
values.This description was created by
for 2f9bb08. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Fixed critical timing issue in SpanProcessor by correcting unit conversion from seconds to milliseconds for flush intervals, ensuring proper batch processing timing.
langfuse/_client/span_processor.py
where seconds were incorrectly interpreted as milliseconds in BatchSpanProcessorlangfuse/_client/environment_variables.py
documentation to clarify LANGFUSE_FLUSH_INTERVAL is in seconds