fix(dataset-run-items): correctly typ datasetRunItems.list #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fix return type of
list()method inDatasetRunItemsClientandAsyncDatasetRunItemsClientto returnPaginatedDatasetRunItems.list()method inDatasetRunItemsClientandAsyncDatasetRunItemsClientnow returnsPaginatedDatasetRunItemsinstead ofNone.reference.mdto reflect the return type change forlist()method.This description was created by
for 0522389. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Improves the DatasetRunItems API by standardizing the
listmethod return type toPaginatedDatasetRunItemsand removing the unnecessaryresponseparameter, making the API more Pythonic and type-safe.langfuse/api/resources/dataset_run_items/client.pyto returnPaginatedDatasetRunItemsdirectly instead of modifying a passed response objectjsonable_encoderimport and simplified method signature in dataset run items clientlangfuse/api/reference.mdto reflect the simplified API interface