Skip to content

Ensure Jupiter's assertions/assumptions are self-contained #4749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 12, 2025
Merged

Ensure Jupiter's assertions/assumptions are self-contained #4749

merged 4 commits into from
Jul 12, 2025

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Jul 10, 2025 •
edited
Loading

  • Avoid reference to Assertions class from production code
  • Add ArchUnit rule ensuring Jupiter Assertions are self-contained
  • Add Checkstyle rule ensuring Jupiter Assertions are self-contained
  • Document how to use Checkstyle rules to forbid Jupiter assertions

Resolves #4604.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp
Avoid reference to Assertions class from production code
420f84e 
`SeparateThreadTimeoutInvocation` called an internal overload of
`Assertions.assertTimeoutPreemptively` to avoid having to duplicate the
implementation of executing a block of code with a preemptive timeout.
Instead, this commit moves the shared code to a new
`PreemptiveTimeoutUtils` class in the new `org.junit.jupiter.api.util`
package which is only exported to the `org.junit.jupiter.engine` module.
@marcphilipp
Add ArchUnit rule ensuring Jupiter Assertions are self-contained
778e6b1
@marcphilipp
Add Checkstyle rule ensuring Jupiter Assertions are self-contained
58d710e
@marcphilipp marcphilipp self-assigned this Jul 10, 2025
@marcphilipp marcphilipp mentioned this pull request Jul 10, 2025
Closed
@marcphilipp marcphilipp marked this pull request as ready for review July 10, 2025 13:34
marcphilipp
marcphilipp commented Jul 11, 2025
View reviewed changes
@marcphilipp marcphilipp force-pushed the marc/4604-self-contained-assertions branch from 12e19ae to 8e4e326 Compare July 12, 2025 11:25
@marcphilipp marcphilipp merged commit 7c41b13 into main Jul 12, 2025
15 checks passed
@marcphilipp marcphilipp deleted the marc/4604-self-contained-assertions branch July 12, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcphilipp marcphilipp

Labels
component: Jupiter theme: documentation type: enhancement type: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure Jupiter's assertions are self-contained
1 participant
@marcphilipp