Skip to content

Allow AVIF and WebP files #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Allow AVIF and WebP files #2504

wants to merge 2 commits into from

Conversation

vanillajonathan
Copy link
Contributor

Allow files with the extensions .avif and .webp.

Allow files with the extensions `.avif` and `.webp`.
@bytestream
Copy link
Member

Can you not just use the accept extension?

@vanillajonathan
Copy link
Contributor Author

I suppose I could but this seems like a reasonable PR. AVIF and WebP are now common on the web so where PNG, JPEG and GIF are accepted AVIF and WebP are expected to be accepted too.

Copy link

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automatically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up.
Thank you for contributing :)

@github-actions github-actions bot added the stale Used to mark stale issues label Dec 14, 2024
@bytestream
Copy link
Member

Someone can correct me if I'm wrong, but after reviewing the Git history I don't think there is precedent for updating existing additional rules. IMO these changes constitute a breaking change and would therefore need to wait until v2. I think you're better off just doing what I suggested, or define your own rule...

@bytestream bytestream closed this Dec 14, 2024
@vanillajonathan vanillajonathan deleted the patch-1 branch December 14, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Used to mark stale issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants