Stop trying to use cPickle, removed from python3 #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cPickle has been removed in python3, and since lazy-object-proxy now only supports python3, we can remove it. The effect of keeping it there is 300+ tests being skipped, confusing the test suite output
|
I think you can go further and replace the parametrization completely (just import pickle normally). |
|
i'm afraid this is all the time i have available to address this problem at the moment. |
|
No worries. |
github-actions bot
added a commit
to MaRDI4NFDI/open-interfaces
that referenced
this pull request
Oct 31, 2022
Bumps [lazy-object-proxy](https://github.com/ionelmc/python-lazy-object-proxy) from 1.7.1 to 1.8.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionelmc/python-lazy-object-proxy/blob/master/CHANGELOG.rst">lazy-object-proxy's changelog</a>.</em></p> <blockquote> <h2>1.8.0 (2022-10-26)</h2> <ul> <li>Cleaned up use of cPickle. Contributed by Sandro Tosi in <code>[#62](ionelmc/python-lazy-object-proxy#62) <https://github.com/ionelmc/python-lazy-object-proxy/pull/62></code>_.</li> <li>Cleaned up more dead Python 2 code.</li> <li>Added Python 3.11 wheels.</li> <li>Dropped support for Python 3.6.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionelmc/python-lazy-object-proxy/commit/5b36b50b678df414e63e5e819350a03723349931"><code>5b36b50</code></a> Bump version: 1.7.1 → 1.8.0</li> <li><a href="https://github.com/ionelmc/python-lazy-object-proxy/commit/568599140dbff3343c2df03887149020822ac302"><code>5685991</code></a> Cleanup more dead code.</li> <li><a href="https://github.com/ionelmc/python-lazy-object-proxy/commit/00a7af890d05e3d9c1a0ac572d12b1330c4cdd27"><code>00a7af8</code></a> Reformat and cleanup some more py2 code.</li> <li><a href="https://github.com/ionelmc/python-lazy-object-proxy/commit/4a940b5429dbc2e96dd70c77370ce15daf72199d"><code>4a940b5</code></a> Update changelog.</li> <li><a href="https://github.com/ionelmc/python-lazy-object-proxy/commit/3244fe625377c332efa7e5e9f9f59645e7e59fe6"><code>3244fe6</code></a> Add python 3.11.</li> <li><a href="https://github.com/ionelmc/python-lazy-object-proxy/commit/8448c233ff12bd1aa11a7297009ddce0608e62f4"><code>8448c23</code></a> Fix pytest deprecation.</li> <li><a href="https://github.com/ionelmc/python-lazy-object-proxy/commit/66f4d9076ad6880027ba784eee68c60315894289"><code>66f4d90</code></a> Up skel.</li> <li><a href="https://github.com/ionelmc/python-lazy-object-proxy/commit/e1def5b1b5104e44e61c7e4cebdeb1d31a6486da"><code>e1def5b</code></a> Up envs.</li> <li><a href="https://github.com/ionelmc/python-lazy-object-proxy/commit/83d7ff3be24acfa45d7df35ce3003c7bf034d959"><code>83d7ff3</code></a> Up skel and some cleanup. Drop py36.</li> <li><a href="https://github.com/ionelmc/python-lazy-object-proxy/commit/03003b012feef472b4bb54b971a8f4782a41f93f"><code>03003b0</code></a> Stop trying to use cPickle, removed from python3</li> <li>See full diff in <a href="https://github.com/ionelmc/python-lazy-object-proxy/compare/v1.7.1...v1.8.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cPickle has been removed in python3, and since lazy-object-proxy now only supports python3, we can remove it.
The effect of keeping it there is 300+ tests being skipped, confusing the test suite output