This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Make InfluxDBClusterClient thread-safe #265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue with InfluxDBClusterClient an multi-threading : it is not thread safe :(
The thread-safe issues I spotted:
For first 2 issues, a simple lock around the affected code solve the issue.
For the last issue, it a bit trickier... I ended with a getter (_get_host() and _get_baseurl()), so InfluxDBClusterClient could override them with code that use a thread local variable.
I've also added properties to avoid changing every access to _host or _baseurl, but since those variables should not be used outside influxdb-python code, we could avoid them and directly use the getter.