Use of six.text type in isinstance #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/179 This is an external review system which you may optionally use for the code review of your pull request. |
|
There are review comments on Critic (I don't think you get notification emails till you first visit). |
|
The intention with the test is to simulate a naive user using Python 2.x and casually adding an attribute without specifying strings as u'att_name' or importing unicode_literals. The tests run by test_treewalker_six_mix will pass on Python 3.x but fail on Python 2.x and the pull-request contains a fix and some suggestions for minor code refactoring ( e.g. to_text and is_text_or_none ) |
added 2 commits
June 22, 2013 22:31
|
Merged in 1d3434f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #63, there are a couple places where
isinstance(varname, six.text_type)is called. This is ok on Python 3, but not on Python 2.This patch fixes the issue. I don't quite understand the format of the included test architecture, so I created a standalone test; included.
All 26941 tests pass on Python 2.7.5+ and 3.2.4 on Debian Jessie.