Skip to content

Fix alignment of Plugin Updates in Horizontal Mode #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2025

Conversation

NorthernMan54
Copy link
Contributor

@NorthernMan54 NorthernMan54 commented Jul 15, 2025

Change was to put back align-items-start

#2478

To fake running in Docker, add these environment variables

declare -x DOCKER_HOMEBRIDGE_VERSION="2025-06-04"
declare -x HOMEBRIDGE_CONFIG_UI="1"

@NorthernMan54 NorthernMan54 requested review from bwp91 and Copilot July 15, 2025 12:51
@github-actions github-actions bot added the beta Related to Beta Branch label Jul 15, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Restores left-aligned layout for the update-info widget in horizontal mode and tidies up the HTML structure.

  • Replaced align-items-center with align-items-start on the main container to align items at the top.
  • Consolidated multi-line attributes into single lines for clickable <div> and <a> elements.
  • Added HTML comments before each service block to help identify sections.
Comments suppressed due to low confidence (3)

ui/src/app/modules/status/widgets/update-info-widget/update-info-widget.component.html:38

  • [nitpick] The comment <!-- Homebridge --> appears in both Docker and non-Docker sections and may be ambiguous. Consider specifying <!-- Docker Homebridge --> and <!-- Standalone Homebridge --> for clarity.
        <!-- Homebridge -->

ui/src/app/modules/status/widgets/update-info-widget/update-info-widget.component.html:9

  • The inline style cursor: pointer is redundant since the cursor-pointer class already sets the pointer cursor. Consider removing the inline style for consistency.
      <div class="d-flex ps-3 py-1 align-items-center cursor-pointer" (click)="toggleDockerExpand()"

ui/src/app/modules/status/widgets/update-info-widget/update-info-widget.component.html:8

  • Multiple elements use the same inline min-width and flex styles. Extract these into a reusable CSS class to reduce duplication and improve maintainability.
    <div class="hb-status-item d-flex flex-column mb-1" style="min-width: max(25%, 200px)">

@NorthernMan54 NorthernMan54 enabled auto-merge (squash) July 15, 2025 12:56
@NorthernMan54 NorthernMan54 merged commit bde717a into beta-5.0.1 Jul 15, 2025
3 checks passed
@NorthernMan54 NorthernMan54 deleted the Docker-Version-Tuning branch July 15, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Related to Beta Branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants