Skip to content

Add light to Huum documentation #40088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

Add light to Huum documentation #40088

merged 2 commits into from
Jul 22, 2025

Conversation

vincentwolsink
Copy link

@vincentwolsink vincentwolsink commented Jul 21, 2025 •
edited
Loading

Proposed change

Add light to Huum documentation

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Jul 21, 2025
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@netlify Netlify
Copy link

netlify bot commented Jul 21, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit dec153e
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/687f3039f1e3010008d7df3e
😎 Deploy Preview https://deploy-preview-40088--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vincentwolsink vincentwolsink mentioned this pull request Jul 21, 2025
Merged
19 tasks
@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jul 21, 2025
@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Jul 21, 2025
joostlek
joostlek requested changes Jul 21, 2025
View reviewed changes
source/_integrations/huum.markdown Outdated

### Light

- **Light**: Sauna light (or ventilation) control (on or off).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or ventilation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the manual, the light relay output can alternately be used to switch a ventilation device. But I’ll remove it to avoid confusion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How big is the chance that someone uses this for a light and how big for a fan?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would I know? 🙂 Probably most people use it for a light. In the Huum app itself it is implemented as a light (and no mention of ventilation tbh). Thats why I implemented it as a light too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that's the info needed. If it was just a generic switch we should have implemented it as a generic switch, which the user can then change using switch_as_x. But if the app indeed shows it as a light, then I think it's fine that we also show it as a light

@home-assistant home-assistant bot marked this pull request as draft July 21, 2025 20:53
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@vincentwolsink vincentwolsink marked this pull request as ready for review July 22, 2025 06:31
@home-assistant home-assistant bot requested a review from joostlek July 22, 2025 06:31
@silamon silamon enabled auto-merge (squash) July 22, 2025 17:30
@silamon silamon merged commit e9234bf into home-assistant:next Jul 22, 2025
7 checks passed
@home-assistant home-assistant bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Jul 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

@silamon silamon silamon approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincentwolsink @joostlek @silamon