Avoid loop when tracing received messages. #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundominguez
force-pushed
the
fd/trace-loop
branch
from
bf0bea7 to
bdcd0f0
Compare
|
hm, had forgotten that tests live now on the same repo as d-p. I just included the tests in this PR then. |
|
Related to #265. |
facundominguez
force-pushed
the
fd/trace-loop
branch
from
bdcd0f0 to
a9949ad
Compare
|
|
||
| #if ! MIN_VERSION_base(4,6,0) | ||
| import Prelude hiding (catch, log) | ||
| #else | ||
| import Prelude hiding ((<*)) |
There was a problem hiding this comment.
Latest prelude that exported catch in prelude 4.4.1, so I suppose we could drop this CPP thing and leave
only import Prelude (in case log should not be hidden)
|
Fails on 7.4 (can be removed from travis) and 7.6 due to build error, |
|
Everything else looks good to me. |
facundominguez
force-pushed
the
fd/trace-loop
branch
from
a9949ad to
b211bf0
Compare
When a trace message was sent to "trace.logger", the NC would produce a trace message to indicate the arrival of it, this new trace message would in turn have the NC produce another trace message and so on. In this patch the NC does not produce a trace message when the destination is the "trace.logger" process.
facundominguez
force-pushed
the
fd/trace-loop
branch
from
b211bf0 to
d8c36b5
Compare
|
We handle those issues in d-process with conditional compilation, can't we do the same here? I mean, distributed-process uses {set,get}Env, in the tracing code... |
Well, issues are solved now. |
facundominguez
added a commit
that referenced
this pull request
Jan 29, 2016
Avoid loop when tracing received messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a trace message was sent to "trace.logger", the NC would produce a trace message to indicate the arrival of it, this new trace message would in turn have the NC produce another trace message and so on.
In this patch the NC does not produce a trace message when the destination is the "trace.logger" process.
Test will be in an upcoming PR of distributed-process-tests.