Skip to content

To the moon and back: Breaking changes! #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 9, 2021
Merged

To the moon and back: Breaking changes! #368

merged 8 commits into from
Jun 9, 2021

Conversation

selfagency
Copy link
Contributor

@selfagency selfagency commented Jun 9, 2021

  • Killed off $gridjs.render in favor of new and improved $gridjs.helper function
  • Changed attribute names where possible to more closely resemble Grid.js API
  • Added automatic re-render on window resize
  • Added support for height, resizable, and fixedHeader options
  • Added @ready event trigger
  • Fixed style overrides issue
  • Fixed per-table stylesheets issue
  • Moved most dependencies to Skypack
  • Added code examples matching those on Grid.js website that also serve as test proofs

Signed-off-by: Daniel Sieradski daniel@self.agency

Signed-off-by: Daniel Sieradski <daniel@self.agency>
Signed-off-by: Daniel Sieradski <daniel@self.agency>
- Added support for height, resizable, and fixedHeader
- Killed off $gridjs.render in favor of new and improved $gridjs.helper function
- Fixed style overrides
- Fixed per-table stylesheets
- Moved most dependencies to Skypack
- Added code examples matching those on Grid.js website that also serve as test proofs

Signed-off-by: Daniel Sieradski <daniel@self.agency>
Signed-off-by: Daniel Sieradski <daniel@self.agency>
Copy link
Member

@afshinm afshinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 well done @selfagency

@selfagency selfagency merged commit 77d97ee into grid-js:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants