Add interface addition event in SchemaDiff #3984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `SchemaDiff.checkImplements` to emit ADDITION events for new interfaces. * Add a loop to iterate over new interfaces and check if they are present in old interfaces. * Emit an ADDITION event if a new interface is not present in the old interfaces. * Retain the existing behavior with respect to interface removals. Add a new test case in `SchemaDiffTest.groovy` to verify that `checkImplements` emits ADDITION events for new interfaces. * Add a test case to cover scenarios where new interfaces are added and old interfaces are removed. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/mgadda/graphql-java?shareId=XXXX-XXXX-XXXX-XXXX).
… not breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
SchemaDiff.checkImplementsto emit ADDITION (info) events for new interfaces. This brings the behavior of SchemaDiff for interfaces into parity with objects, enums, unions, etc with respect to additions.Details
Testing
Add a new test case in
SchemaDiffTest.groovyto verify thatcheckImplementsemits ADDITION events for new interfaces.