Skip to content

v2.0 : Differiented between input and output strings on nullability rules in the format strategy configuraiton #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2024
Merged

v2.0 : Differiented between input and output strings on nullability rules in the format strategy configuraiton #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e11a672
WIP, split non-null string options into input and output strings
kevin-carroll Apr 29, 2024
6c56a54
renamed schema format strategy
kevin-carroll May 17, 2024
d0a2aca
WIP, removed the need for an exposed "name formatter"
kevin-carroll May 18, 2024
3a2cd51
WIP, revamped nullability settings and name formatters to be "rule ba…
kevin-carroll May 19, 2024
d83d169
WIP, variable name and schema strategy builder clean up
kevin-carroll May 26, 2024
c97b734
WIP, tests and inline documentation updates
kevin-carroll May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions src/ancillary-projects/starwars/starwars-api70/Program.cs
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions src/ancillary-projects/starwars/starwars-api70/Properties/launchSettings.json
View file
Open in desktop

This file was deleted.

174 changes: 0 additions & 174 deletions src/ancillary-projects/starwars/starwars-api70/Startup.cs
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions src/ancillary-projects/starwars/starwars-api70/appsettings.json
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions src/ancillary-projects/starwars/starwars-api70/starwars-api70.csproj
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions src/graphql-aspnet-subscriptions/Attributes/SubscriptionRootAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ namespace GraphQL.AspNet.Attributes
{
using System;
using System.Linq;
using GraphQL.AspNet.Common.Extensions;
using GraphQL.AspNet.Execution;
using GraphQL.AspNet.Interfaces.Schema;

Expand Down Expand Up @@ -92,15 +91,15 @@ public SubscriptionRootAttribute(string template, Type returnType, params Type[]
/// </summary>
/// <param name="template">The template naming scheme to use to generate a graph field from this method.</param>
/// <param name="unionTypeName">Name of the union type.</param>
/// <param name="unionTypeA">The first of two required types to include in the union.</param>
/// <param name="firstUnionType">The first of two required types to include in the union.</param>
/// <param name="additionalUnionTypes">Any additional union types.</param>
public SubscriptionRootAttribute(string template, string unionTypeName, Type unionTypeA, params Type[] additionalUnionTypes)
public SubscriptionRootAttribute(string template, string unionTypeName, Type firstUnionType, params Type[] additionalUnionTypes)
: base(
true,
ItemPathRoots.Subscription,
template,
unionTypeName,
(new Type[] { unionTypeA }).Concat(additionalUnionTypes ?? Enumerable.Empty<Type>()).ToArray())
(new Type[] { firstUnionType }).Concat(additionalUnionTypes ?? Enumerable.Empty<Type>()).ToArray())
{
this.EventName = null;
}
Expand Down
7 changes: 0 additions & 7 deletions src/graphql-aspnet.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "graphql-aspnet-subscription
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "graphql-aspnet-subscriptions-tests", "unit-tests\graphql-aspnet-subscriptions-tests\graphql-aspnet-subscriptions-tests.csproj", "{6E4A16F5-1B98-412E-9A88-F56301F5D0E4}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "starwars-api70", "ancillary-projects\starwars\starwars-api70\starwars-api70.csproj", "{B92A5C91-F88D-4F26-8775-20C72692BD43}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "graphql-aspnet-tests-common", "unit-tests\graphql-aspnet-tests-common\graphql-aspnet-tests-common.csproj", "{3CB086E3-5E7B-438B-9A95-AEA264009521}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "starwars-api80", "ancillary-projects\starwars\starwars-api80\starwars-api80.csproj", "{43C9EB6E-5FFE-4EC6-B21B-09C715B7B114}"
Expand Down Expand Up @@ -70,10 +68,6 @@ Global
{6E4A16F5-1B98-412E-9A88-F56301F5D0E4}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{6E4A16F5-1B98-412E-9A88-F56301F5D0E4}.Debug|Any CPU.Build.0 = Debug|Any CPU
{6E4A16F5-1B98-412E-9A88-F56301F5D0E4}.Release|Any CPU.ActiveCfg = Release|Any CPU
{B92A5C91-F88D-4F26-8775-20C72692BD43}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{B92A5C91-F88D-4F26-8775-20C72692BD43}.Debug|Any CPU.Build.0 = Debug|Any CPU
{B92A5C91-F88D-4F26-8775-20C72692BD43}.Release|Any CPU.ActiveCfg = Release|Any CPU
{B92A5C91-F88D-4F26-8775-20C72692BD43}.Release|Any CPU.Build.0 = Release|Any CPU
{3CB086E3-5E7B-438B-9A95-AEA264009521}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{3CB086E3-5E7B-438B-9A95-AEA264009521}.Debug|Any CPU.Build.0 = Debug|Any CPU
{3CB086E3-5E7B-438B-9A95-AEA264009521}.Release|Any CPU.ActiveCfg = Release|Any CPU
Expand All @@ -96,7 +90,6 @@ Global
{5F6EBAF4-B5EB-4DBD-8F51-17BBC2E8984D} = {22C7BC5B-EC8E-4A07-9968-961E86AB44E2}
{5DE081AA-494A-4377-B2CA-6952715D513D} = {350D3594-5D97-4D9B-A01D-D3A5C036318C}
{6E4A16F5-1B98-412E-9A88-F56301F5D0E4} = {350D3594-5D97-4D9B-A01D-D3A5C036318C}
{B92A5C91-F88D-4F26-8775-20C72692BD43} = {22C7BC5B-EC8E-4A07-9968-961E86AB44E2}
{3CB086E3-5E7B-438B-9A95-AEA264009521} = {350D3594-5D97-4D9B-A01D-D3A5C036318C}
{43C9EB6E-5FFE-4EC6-B21B-09C715B7B114} = {22C7BC5B-EC8E-4A07-9968-961E86AB44E2}
{E67D4FB2-73FF-4EC1-80F8-5D4DEC57F5AA} = {350D3594-5D97-4D9B-A01D-D3A5C036318C}
Expand Down
7 changes: 3 additions & 4 deletions src/graphql-aspnet/Attributes/MutationAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ namespace GraphQL.AspNet.Attributes
{
using System;
using System.Linq;
using GraphQL.AspNet.Common.Extensions;
using GraphQL.AspNet.Execution;
using GraphQL.AspNet.Interfaces.Schema;

Expand Down Expand Up @@ -101,15 +100,15 @@ public MutationAttribute(string template, Type returnType, params Type[] additio
/// </summary>
/// <param name="template">The template naming scheme to use to generate a graph field from this method.</param>
/// <param name="unionTypeName">Name of the union type.</param>
/// <param name="unionTypeA">The first of two required types to include in the union.</param>
/// <param name="firstUnionType">The first of two required types to include in the union.</param>
/// <param name="additionalUnionTypes">Any additional union types.</param>
public MutationAttribute(string template, string unionTypeName, Type unionTypeA, params Type[] additionalUnionTypes)
public MutationAttribute(string template, string unionTypeName, Type firstUnionType, params Type[] additionalUnionTypes)
: base(
false,
ItemPathRoots.Mutation,
template,
unionTypeName,
(new Type[] { unionTypeA }).Concat(additionalUnionTypes ?? Enumerable.Empty<Type>()).ToArray())
(new Type[] { firstUnionType }).Concat(additionalUnionTypes ?? Enumerable.Empty<Type>()).ToArray())
{
}
}
Expand Down
7 changes: 3 additions & 4 deletions src/graphql-aspnet/Attributes/MutationRootAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ namespace GraphQL.AspNet.Attributes
{
using System;
using System.Linq;
using GraphQL.AspNet.Common.Extensions;
using GraphQL.AspNet.Execution;
using GraphQL.AspNet.Interfaces.Schema;

Expand Down Expand Up @@ -100,15 +99,15 @@ public MutationRootAttribute(string template, Type returnType, params Type[] add
/// </summary>
/// <param name="template">The template naming scheme to use to generate a graph field from this method.</param>
/// <param name="unionTypeName">Name of the union type.</param>
/// <param name="unionTypeA">The first of two required types to include in the union.</param>
/// <param name="firstUnionType">The first of two required types to include in the union.</param>
/// <param name="additionalUnionTypes">Any additional union types.</param>
public MutationRootAttribute(string template, string unionTypeName, Type unionTypeA, params Type[] additionalUnionTypes)
public MutationRootAttribute(string template, string unionTypeName, Type firstUnionType, params Type[] additionalUnionTypes)
: base(
true,
ItemPathRoots.Mutation,
template,
unionTypeName,
(new Type[] { unionTypeA }).Concat(additionalUnionTypes ?? Enumerable.Empty<Type>()).ToArray())
(new Type[] { firstUnionType }).Concat(additionalUnionTypes ?? Enumerable.Empty<Type>()).ToArray())
{
}
}
Expand Down
7 changes: 3 additions & 4 deletions src/graphql-aspnet/Attributes/QueryAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ namespace GraphQL.AspNet.Attributes
{
using System;
using System.Linq;
using GraphQL.AspNet.Common.Extensions;
using GraphQL.AspNet.Execution;
using GraphQL.AspNet.Interfaces.Schema;

Expand Down Expand Up @@ -101,15 +100,15 @@ public QueryAttribute(string template, Type returnType, params Type[] additional
/// </summary>
/// <param name="template">The template naming scheme to use to generate a graph field from this method.</param>
/// <param name="unionTypeName">Name of the union type.</param>
/// <param name="unionTypeA">The first type to include in the union.</param>
/// <param name="firstUnionType">The first type to include in the union.</param>
/// <param name="additionalUnionTypes">Any additional union types to include.</param>
public QueryAttribute(string template, string unionTypeName, Type unionTypeA, params Type[] additionalUnionTypes)
public QueryAttribute(string template, string unionTypeName, Type firstUnionType, params Type[] additionalUnionTypes)
: base(
false,
ItemPathRoots.Query,
template,
unionTypeName,
(new Type[] { unionTypeA }).Concat(additionalUnionTypes ?? Enumerable.Empty<Type>()).ToArray())
(new Type[] { firstUnionType }).Concat(additionalUnionTypes ?? Enumerable.Empty<Type>()).ToArray())
{
}
}
Expand Down
Loading