Skip to content

store: ensure consistent id type in FindRangeQuery SQL output #6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Jul 17, 2025

When using subgraph composition and indexing entity of different type id, the subgraph wouldn't sync due to the below error

UNION types bytea and text cannot be matched

This was because the FindRangeQuery SQL generator wasn't casting entity IDs to a consistent type, causing UNION ALL operations to fail when merging results from subgraphs with different ID types

@shiyasmohd shiyasmohd requested a review from incrypto32 July 17, 2025 13:34
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/fix-subgraph-composition-diff-entity-id branch 7 times, most recently from 56e2f5a to f1151a6 Compare July 17, 2025 19:54
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/fix-subgraph-composition-diff-entity-id branch from f1151a6 to 5a52078 Compare July 18, 2025 09:10
@shiyasmohd shiyasmohd self-assigned this Jul 18, 2025
@shiyasmohd
Copy link
Contributor Author

shiyasmohd commented Jul 18, 2025

@incrypto32 Changes:

  • Added unit test in query_tests.rs
  • Covered different entity id for source subgraph case in integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants