Skip to content

ci: upgrade to Go 1.11.5 #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2019
Merged

ci: upgrade to Go 1.11.5 #903

merged 1 commit into from
Mar 9, 2019

Conversation

myitcv
Copy link
Member

@myitcv myitcv commented Mar 9, 2019

So that we can then see the true diff that the Go 1.12 changes in
#900 will introduce.

@myitcv myitcv requested a review from hajimehoshi March 9, 2019 14:48
@hajimehoshi
Copy link
Member

Thank you!

# go run run.go -- fixedbugs/issue28688.go
exit status 2
Error: unknown shorthand flag: 'g' in -gcflags=-d=softfloat
Usage:
  gopherjs run [gofiles...] [arguments...] [flags]

Flags:
      --color         colored output
  -h, --help          help for run
      --localmap      use local paths for sourcemap
  -m, --minify        minify generated code
  -q, --quiet         suppress non-fatal warnings
      --tags string   a list of build tags to consider satisfied during the build
  -v, --verbose       print the names of packages as they are compiled


FAIL	fixedbugs/issue28688.go	0.006s

Is this an intended error?

@myitcv
ci: upgrade to Go 1.11.5
cd658a9 
So that we can then see the true diff that the Go 1.12 changes in
gopherjs#900 will introduce.
@myitcv
Copy link
Member Author

myitcv commented Mar 9, 2019

@hajimehoshi - the way the error is reported looks like another issue, but this test can itself be ignored because it looks related to checking runtime optimisations. Hence I've added it to the list of notApplicable tests that can be ignored.

hajimehoshi
hajimehoshi approved these changes Mar 9, 2019
View reviewed changes
Copy link
Member

@hajimehoshi hajimehoshi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (as long as the tests succeed)

@myitcv myitcv merged commit 847fc94 into gopherjs:master Mar 9, 2019
@myitcv myitcv deleted the go1.11.5 branch March 9, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajimehoshi hajimehoshi hajimehoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myitcv @hajimehoshi