Deprecate ChooseVersion helper
#3436
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
semver:minor
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
As noted inline, this uses relative URLs which will be important shortly. We also tweak the Magnum one, stripping a lot of irrelevant fields. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
stephenfin
force-pushed
the
endpoint-discovery
branch
from
3aaafff to
48c8c06
Compare
These can be useful to do service discovery. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Per the inline deprecation notice. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
stephenfin
force-pushed
the
endpoint-discovery
branch
from
48c8c06 to
88e45ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a TODO from #3420 and both deprecate the function and migrate our sole user of it away.