Skip to content

neutron: add more quotas members #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Jun 13, 2025

An addition to #1742

@kayrus kayrus added the backport-v2 This PR will be backported to v2 label Jun 13, 2025
@github-actions github-actions bot added edit:networking This PR updates networking code semver:minor Backwards-compatible change labels Jun 13, 2025
@coveralls
Copy link

coveralls commented Jun 13, 2025

Coverage Status

coverage: 63.704%. remained the same
when pulling b5851c1 on kayrus:new-neutron-quota
into 992e8b7 on gophercloud:main.

Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to have these in openstack/networking/v2/extensions/fwaas_v2 and openstack/networking/v2/extensions/bgpvpns, as a similar fashion that we're doing for MTU for example?

@kayrus
Copy link
Contributor Author

kayrus commented Jun 17, 2025

To be honest I don't know. Existing support for rbac policies extension already resides in the quota package.

@kayrus kayrus force-pushed the new-neutron-quota branch from 82c811d to b5851c1 Compare June 19, 2025 14:28
@kayrus kayrus requested a review from mandre June 25, 2025 07:17
@kayrus
Copy link
Contributor Author

kayrus commented Jun 25, 2025

@mandre I think once these new struct members are pointers, it is ok to keep them here. They will be ignored if they're not defined.

@mandre
Copy link
Contributor

mandre commented Jun 26, 2025

I'm not sure either. Let's ask the other maintainers.
@gophercloud/core any opinion on where the quota fields for neutron extensions should live?

Should we add them to openstack/networking/v2/extensions/fwaas_v2 for fwaas quota similar to what we're doing for MTU, or add them directly to openstack/networking/v2/extensions/quotas/ like we've already done for RBAC policy?

@stephenfin
Copy link
Contributor

stephenfin commented Jun 26, 2025

I'd be personally in favour of the former, if this is possible, seeing as these are quotas for an extension. Any extension can define its own quota, so this could quickly get out of hand otherwise. My 2c

@stephenfin
Copy link
Contributor

For context, networing-bgpvpn, neutron-fwaas and networking-sfc all register resource quotas. tap-as-a-service does not.

@kayrus
Copy link
Contributor Author

kayrus commented Jul 16, 2025

I shared my thoughts on moving this into a new extension in #3447 (comment). Using pointers for these struct members should be safe and should not introduce issues. Creating separate packages for each individual option, however, could add unnecessary complexity and negatively impact the developer experience for SDK users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v2 This PR will be backported to v2 edit:networking This PR updates networking code semver:minor Backwards-compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants