-
Notifications
You must be signed in to change notification settings - Fork 559
neutron: add more quotas members #3424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make more sense to have these in openstack/networking/v2/extensions/fwaas_v2
and openstack/networking/v2/extensions/bgpvpns
, as a similar fashion that we're doing for MTU for example?
To be honest I don't know. Existing support for rbac policies extension already resides in the quota package. |
82c811d
to
b5851c1
Compare
@mandre I think once these new struct members are pointers, it is ok to keep them here. They will be ignored if they're not defined. |
I'm not sure either. Let's ask the other maintainers. Should we add them to |
I'd be personally in favour of the former, if this is possible, seeing as these are quotas for an extension. Any extension can define its own quota, so this could quickly get out of hand otherwise. My 2c |
For context, |
I shared my thoughts on moving this into a new extension in #3447 (comment). Using pointers for these struct members should be safe and should not introduce issues. Creating separate packages for each individual option, however, could add unnecessary complexity and negatively impact the developer experience for SDK users. |
An addition to #1742