Skip to content

access_token: encrypt access token with SHA256 #7008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 5, 2022
Merged

access_token: encrypt access token with SHA256 #7008

merged 21 commits into from
Jun 5, 2022

Conversation

wuhan005
Copy link
Member

@wuhan005 wuhan005 commented Jun 4, 2022 •
edited by unknwon
Loading

Describe the pull request

Link to the issue: fixes #6570

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

@codecov
Copy link

codecov bot commented Jun 4, 2022 •
edited
Loading

Codecov Report

Merging #7008 (a522163) into main (64e0947) will increase coverage by 0.05%.
The diff coverage is 65.21%.

@@           Coverage Diff            @@
##            main   #7008      +/-   ##
========================================
+ Coverage   8.92%   8.98%   +0.05%     
========================================
  Files         99      99              
  Lines      13282   13293      +11     
========================================
+ Hits        1186    1194       +8     
- Misses     11930   11932       +2     
- Partials     166     167       +1

@wuhan005 wuhan005 marked this pull request as ready for review June 4, 2022 11:24
@wuhan005 wuhan005 requested a review from a team June 4, 2022 11:25
unknwon
unknwon reviewed Jun 4, 2022
View reviewed changes
unknwon
unknwon requested changes Jun 4, 2022
View reviewed changes
@unknwon
Copy link
Member

unknwon commented Jun 4, 2022

Please also add a changelog entry.

@unknwon unknwon added this to the 0.13.0 milestone Jun 4, 2022
unknwon
unknwon reviewed Jun 4, 2022
View reviewed changes
unknwon
unknwon approved these changes Jun 5, 2022
View reviewed changes
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@wuhan005 wuhan005 merged commit a328e7c into main Jun 5, 2022
@wuhan005 wuhan005 deleted the wh/access-token/sha256 branch June 5, 2022 05:34
dna2github pushed a commit to dna2fork/gogs that referenced this pull request May 1, 2023
@wuhan005 @unknwon @dna2github
access_token: encrypt access token with SHA256 (gogs#7008)
8d24d1a 
* access_token: encrypt access token with SHA256

* revert list access token

* fix lint

* generate schemadoc

* add database migrations

* fix tests

* fix tests

* add test case for access token golden

* fix test in postgres

* `Sha256` -> `SHA256`

* Use GORM for migration

* task generate-schemadoc

* Use unique

* change migration name

* allow read

* task generate-schemadoc

* add changelog

* fix lint error

* update changelog

* remove Debug

* add comments

Co-authored-by: Joe Chen <jc@unknwon.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unknwon unknwon unknwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Gogs Roadmap
Status: Done
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

Insecure access token storage
2 participants
@wuhan005 @unknwon