To install the newest go-bindata, use the following:

% go get -u github.com/go-bindata/go-bindata/...

Thanks for the PR!

According to https://github.com/gogs/gogs/blob/master/conf/README.md, you should use https://github.com/kevinburke/go-bindata. Can you verify the result is the same? Or re-generate if necessary.

sorry, I don't notice the go-bindata need use github.com/kevinburke/go-bindata. Compare github.com/go-bindata/go-bindata, the github.com/kevinburke/go-bindata not support generate create http.FileSystem instance code by go-bindata -fs ... that PR supported by github.com/go-bindata/go-bindata.

This patch depend go-bindata generate a function to returan a http.FileSystem in internal/assets/public so have 3 solutions fix this patch:

1. use github.com/go-bindata/go-bindata to generate static files.
2. commit a PR to github.com/kevinburke/go-bindata to support generate create http.FileSystem instance code like PR.I will do this later but need github.com/kevinburke/go-bindata to merge.
3. add a custom function in native to create a http.FileSystem instance from generated static public files code.

I think github.com/go-bindata/go-bindata is good same as github.com/kevinburke/go-bindata so how about use github.com/go-bindata/go-bindata as our generate tool.

I think github.com/go-bindata/go-bindata is good same as github.com/kevinburke/go-bindata so how about use github.com/go-bindata/go-bindata as our generate tool.

Gogs used to use github.com/go-bindata/go-bindata but has changed to use github.com/kevinburke/go-bindata because that's the one installed by brew install go-bindata.

3. add a custom function in native to create a http.FileSystem instance from generated static public files code.

I think this is my preferred solution.

Besides, (I haven't looked at code in detail), it would be nice to have:

1. In dev mode, it reads directly from the file system.
2. In non-dev mode, it reads from what's been embedded.

Had optimize patch:

1. use github.com/kevinburke/go-bindata as generate tool.
2. add a custom function to instance a http.FileSystem from generated static public assets code.
3. add ENABLE_ASSETS = true item in configure file to support either enable use embedded public and templates assets (not use RUN_MODE item because sometimes we just test enable embedded public assets feature in dev mode and other scenes).

Thanks again for the contribution!

PS: If you think you don't have bandwidth work on this in the coming week, LMK! I'll push changes to this PR. I want to get this merged :)

Thanks your suggestions. I had update the patch and welcome optimize the code :)

OK, I think I'm happy with the current state, merging!

Is there any possibility to edit the templates without recompiling?
Background, we used a custom home template adding a logo and different text.

@ozzi- A restart of Gogs is all you need if you are editing files under custom/ directory.