Skip to content

Update the commit template to receive more options #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2017
Merged

Update the commit template to receive more options #88

merged 2 commits into from
Sep 30, 2017

Conversation

alexcanessa
Copy link
Member

The commit message was the only template that didn't have many options.

Now the commit can use these options:

  • author
  • sha
  • url
  • message

The options are:

  1. Via string in the .grenrc.json file
{
    template: {
        "commit": "- [{{message}}]({{url}}) - @{{author}}"
    }
}
  1. Via function in the .grenrc.js file
module.exports = {
    template: {
        commit: ({ author, url, message}) => `- @${author}: [${message}](${url})`)
}

resolves #72

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-0.10.0@b5915c7). Click here to learn what that means.
The diff coverage is 93.75%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release-0.10.0      #88   +/-   ##
=================================================
  Coverage                  ?   79.39%           
=================================================
  Files                     ?        7           
  Lines                     ?      330           
  Branches                  ?        0           
=================================================
  Hits                      ?      262           
  Misses                    ?       68           
  Partials                  ?        0
Impacted Files Coverage Δ
lib/src/Gren.js 75.46% <93.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5915c7...7caf1bc. Read the comment docs.

@alexcanessa alexcanessa merged commit f4c7a8b into release-0.10.0 Sep 30, 2017
@alexcanessa alexcanessa deleted the feat-72 branch September 30, 2017 12:49
@alexcanessa alexcanessa mentioned this pull request Oct 8, 2017
Merged
alexcanessa added a commit that referenced this pull request Oct 8, 2017
@alexcanessa
Update the commit template to receive more options (#88)
09e4b25 
* Update the filter otion for the commit to accept all the options

* Add options to the commit messages
@alexcanessa alexcanessa mentioned this pull request Oct 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcanessa @codecov-io