Skip to content

Organization API support #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

davidcorbin
Copy link

I created two methods that I needed for a project I'm working on. I plan on adding support for the rest of the Organization API on the weekend.

// Organization API
// =======

Github.Organization = function (org) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the aim of the org parameter here? It isn't used in your code.

@AurelioDeRosa
Copy link
Member

Thank you for this PR. I've added a few comments for your review. Also, could you update the README file as well to document these new methods?

@davidcorbin
Copy link
Author

@AurelioDeRosa I believe I fixed all the comments you had. I can squash all the commits into one before you merge if you'd like. 😄

@AurelioDeRosa
Copy link
Member

Hi @daconex.

Thank you for taking the time to update your PR. Before I merge it, there is one last change I'd like you to do. I think that a instead of checkMembership we name the method isMember. Apart from that, all looks good.

@AurelioDeRosa
Copy link
Member

Hi @daconex.

Can you do the last change required and rebase so that I can merge your PR? Thank you.

@clayreimann
Copy link
Member

@davidcorbin This was just released in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants