Avoiding callback errors #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon successful response, if there is no responseText output true (Stops a callback errors being created with some API calls when actually everything went well)
punchagan
pushed a commit
to punchagan/github
that referenced
this pull request
Aug 23, 2014
Ability to specify organisation into which to fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If on success there is no XHR responseText, output true instead to avoid errors being created in callback.
For instance, delete a gist, there is no callback text to pass back and currently this causes an error. With this change it now passes back true instead, which is a more positive response that actually everything went well.