Skip to content

Update rubocop related dependencies #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update rubocop related dependencies #72

wants to merge 1 commit into from

Conversation

HParker
Copy link
Contributor

@HParker HParker commented Jul 20, 2020

No description provided.

composerinteralia
composerinteralia approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@composerinteralia composerinteralia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about removing the constraints on "rubocop-performance" and "rubocop-rails" as well? My general feeling is that version constraints in gems make upgrades more challenging and don't provide much value except in the case where there is a known conflict between versions.

@HParker HParker force-pushed the unlock-rubocop-version branch from cf02c88 to e1cc488 Compare July 20, 2020 19:09
@composerinteralia
Copy link
Member

Actually I might be wrong in this case. It looks like we are locking the version in this case so we can coordinate updating the gem with updating the yaml file (see e82e9b2 for example). Maybe we should bump to whatever the latest version is instead?

@HParker
Copy link
Contributor Author

HParker commented Jul 20, 2020

Ah, I suppose without that version lock CI might just start failing on an unrelated change. I'll update this to lock to latest versions of those 3 gems so that we can at least prevent these gems updating on unrelated changes here.

@HParker
Update rubocop related dependencies
ba58491 
Update version requirement on,
- rubocop
- rubocop-performance
- rubocop-rails
@HParker HParker force-pushed the unlock-rubocop-version branch from e1cc488 to ba58491 Compare July 20, 2020 19:13
@HParker HParker changed the title Unlock rubocop to allow rubocop 0.88.x and beyond Update rubocop related dependencies Jul 20, 2020
composerinteralia
composerinteralia approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@composerinteralia composerinteralia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that makes sense. Thanks!

@HParker HParker mentioned this pull request Aug 7, 2020
Merged
@HParker HParker closed this Aug 7, 2020
@HParker HParker deleted the unlock-rubocop-version branch August 7, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@composerinteralia composerinteralia composerinteralia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HParker @composerinteralia