Single Token Input #121
Merged
Single Token Input #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmacgowan
requested changes
Nov 27, 2023
Co-authored-by: Jason Macgowan <1389531+jasonmacgowan@users.noreply.github.com>
jasonmacgowan
approved these changes
Nov 27, 2023
elopezacosta
approved these changes
Nov 27, 2023
kodiakhq bot
referenced
this pull request
in weareinreach/TransMascFutures
Nov 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github/privileged-requester](https://togithub.com/github/privileged-requester) | action | major | `v1.1.0` -> `v2.0.0` | --- ### Release Notes <details> <summary>github/privileged-requester (github/privileged-requester)</summary> ### [`v2.0.0`](https://togithub.com/github/privileged-requester/releases/tag/v2.0.0) [Compare Source](https://togithub.com/github/privileged-requester/compare/v1.1.0...v2.0.0) ####⚠️ Breaking Changes⚠️ The following inputs options are now **deprecated**: - `myToken` - `robotUserToken` They are now replaced with just a single input option called [`github_token`](https://togithub.com/github/privileged-requester/blob/020a53bc1a3c4500c216c7c8100a58b0e6d7381e/action.yml#L7-L13). By default, this option will assume the default GitHub Actions token (`${{ github.token }}`) and it will inherit your workflow's permissions. You can optionally overwrite this value with a [GitHub PAT](https://docs.github.com/en/rest/orgs/personal-access-tokens?apiVersion=2022-11-28). #### What's Changed - Single Token Input by [@​GrantBirki](https://togithub.com/GrantBirki) in [https://github.com/github/privileged-requester/pull/121](https://togithub.com/github/privileged-requester/pull/121) - ensure all handles are treated the same (as lowercase) by [@​GrantBirki](https://togithub.com/GrantBirki) in [https://github.com/github/privileged-requester/pull/122](https://togithub.com/github/privileged-requester/pull/122) - improved logging by [@​GrantBirki](https://togithub.com/GrantBirki) in [https://github.com/github/privileged-requester/pull/123](https://togithub.com/github/privileged-requester/pull/123) - Node Updates by [@​GrantBirki](https://togithub.com/GrantBirki) in [https://github.com/github/privileged-requester/pull/124](https://togithub.com/github/privileged-requester/pull/124) **Full Changelog**: github/privileged-requester@v1.1.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/GLAAD). PR-URL: #264 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Joe Karow <58997957+JoeKarow@users.noreply.github.com>
%5D(https%3A%2F%2Frenovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single Token Input
This pull request refactors this Action in the following ways:
github_token. By default, this input option will assume thegithub.tokensecret that the workflow run uses. You can optionally overwrite this input option with your own GitHub PAT or the PAT of a bot accountWhy?
There is inconsistency in the way this Action runs when a robot user token is not provided. See the example below where no robot token is provided, yet the Action tries to use one anyways:
Additionally, it is confusing to the end-user that is installing this workflow in their repository. There should be a single input for the token which this Action should use. That input should default to the permissions scoped to the Actions workflow, then it can be overwritten by the user should they choose to do so. This pull request does exactly that.