Add CI build for OpenLDAP integration #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| script: | ||
| - if [ "$TESTENV" = "openldap" ]; then ./script/cibuild-openldap; fi | ||
| - if [ "$TESTENV" = "apacheds" ]; then ./script/cibuild-apacheds; fi |
There was a problem hiding this comment.
The way you have it also works, but the install and script sections can be dried up a bit:
# if file exists, run it
[ -f ./script/install-$TESTENV ] && ./script/install-$TESTENV
[ -f ./script/cibuild-$TESTENV ] && ./script/cibuild-$TESTENVSame with the above.
cc Travis docs The Build Matrix for reference.
There was a problem hiding this comment.
I'm wary of trying to DRY every reference, feels like too much indirection without a ton of value add.
There was a problem hiding this comment.
Fine with me. I don't imagine this section to grow significantly more complex. Both of them are easily readable for me.
|
👍 good start. cc me again when you have more build configurations added. |
|
Bah, just realized I created this PR against |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early work to add tests using OpenLDAP for #46.
cc @jch