Skip to content

Update rubocop requirement from = 1.52.1 to = 1.53.0 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Update rubocop requirement from = 1.52.1 to = 1.53.0 #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
525453e
Update rubocop requirement from = 1.52.1 to = 1.53.0
dependabot[bot] Jun 26, 2023
f4a2adc
explicit return false
lindseywild Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ GEM
i18n (1.13.0)
concurrent-ruby (~> 1.0)
json (2.6.3)
language_server-protocol (3.17.0.3)
loofah (2.21.3)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
Expand All @@ -53,7 +54,7 @@ GEM
parser (3.2.2.3)
ast (~> 2.4.1)
racc
racc (1.6.2)
racc (1.7.1)
rack (3.0.4.1)
rails-dom-testing (2.0.3)
activesupport (>= 4.2.0)
Expand All @@ -65,8 +66,9 @@ GEM
rake (13.0.6)
regexp_parser (2.8.1)
rexml (3.2.5)
rubocop (1.52.1)
rubocop (1.53.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.3)
rainbow (>= 2.2.2, < 4.0)
Expand Down Expand Up @@ -104,7 +106,7 @@ DEPENDENCIES
minitest (~> 5.18.0)
mocha (~> 2.0.2)
rake (~> 13.0.6)
rubocop (= 1.52.1)
rubocop (= 1.53.0)
rubocop-github (~> 0.20.0)

BUNDLED WITH
Expand Down
2 changes: 1 addition & 1 deletion erblint-github.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Gem::Specification.new do |s|
s.add_development_dependency "mocha", "~> 2.0.2"
s.add_development_dependency "rake", "~> 13.0.6"

s.add_development_dependency "rubocop", "= 1.52.1"
s.add_development_dependency "rubocop", "= 1.53.0"
s.add_development_dependency "rubocop-github", "~> 0.20.0"
s.metadata["rubygems_mfa_required"] = "true"
end
2 changes: 1 addition & 1 deletion lib/erblint-github/linters/custom_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def counter_correct?(processed_source)
if offenses_count.zero?
# have to adjust to get `\n` so we delete the whole line
add_offense(processed_source.to_source_range(comment_node.loc.adjust(end_pos: 1)), "Unused erblint:counter comment for #{rule_name}", "") if comment_node
return
return false
end

first_offense = @offenses[0]
Expand Down