Skip to content

Fix invalid raw markup #8370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2021
Merged

Fix invalid raw markup #8370

merged 1 commit into from
Jul 19, 2021

Conversation

oliversalzburg
Copy link
Contributor

Why:

Closes #8339

What's being changed:

The closing endraw tag was actually missing and a raw tag was placed instead, leaving marker fragments in the finally rendered code block.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@oliversalzburg
Fix invalid raw markup
21e5d05 
The closing `endraw` tag was actually missing and a `raw` tag was placed instead, leaving marker fragments in the finally rendered code block
@welcome
Copy link

welcome bot commented Jul 19, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 19, 2021
jmarlena
jmarlena approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@jmarlena jmarlena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR and surfacing this issue. These changes look ready to ship once all the tests go green!

@jmarlena jmarlena merged commit 8c23404 into github:main Jul 19, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@oliversalzburg oliversalzburg deleted the patch-2 branch July 20, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarlena jmarlena jmarlena approved these changes

Assignees
No one assigned
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid raw markers in code samples
2 participants
@oliversalzburg @jmarlena